After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687519 - 3.6 regression: Toggle buttons states are the same for selected/not selected
3.6 regression: Toggle buttons states are the same for selected/not selected
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK2 theme
Other Linux
: Normal major
: ---
Assigned To: gnome-themes-standard-maint
Depends on:
Reported: 2012-11-03 16:30 UTC by Venator85
Modified: 2012-11-30 21:45 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Screenshot showing the issue (75.28 KB, image/png)
2012-11-03 16:30 UTC, Venator85
gtk2: Fix selected toggle button styling in SWT (770 bytes, patch)
2012-11-24 12:13 UTC, Robin Stocker
none Details | Review

Description Venator85 2012-11-03 16:30:02 UTC
Created attachment 227968 [details]
Screenshot showing the issue

I just upgraded to Gnome 3.6, but since then there are some issues with Eclipse buttons. Specifically, toggle buttons states for selected/not selected appear to be the same, with only the text color being slightly darker when selected. See the attached screenshot.
This happens with both Eclipse 4.2 and 3.7, and it didn't happen on Gnome 3.4.
Reproducible on both Arch Linux as of November 3, 2012, and UbuntuGNOME 12.10.
Comment 1 Robin Stocker 2012-11-24 11:56:55 UTC
Eclipse 4.2 and 3.7 are still using GTK 2 for now, so the bug is actually in the Adwaita GTK 2 theme -> changed component.

Apart from that, I can confirm the problem. It's pretty confusing when switching between perspectives.
Comment 2 Robin Stocker 2012-11-24 12:13:26 UTC
Created attachment 229759 [details] [review]
gtk2: Fix selected toggle button styling in SWT

Patch against gnome-3-6 which fixes the issue. I don't know why that line was there in the first place though.
Comment 3 Cosimo Cecchi 2012-11-24 17:36:57 UTC
Thanks for the report and the patch; that line has been there since the first import of the GTK2 Bridge theme, so I assumed it worked...I think the intent is to remove an additional background some toolbars render in Eclipse.
I pushed a slightly different patch, which should still fix the reported issue but avoids changing the toolbars' look.
Comment 4 Robin Stocker 2012-11-27 11:55:22 UTC
Thanks Cosimo, your work is very much appreciated! Will verify soon.
Comment 5 Robin Stocker 2012-11-30 21:45:12 UTC
Verified, good job.