After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687516 - typo in string: KB should be kB
typo in string: KB should be kB
Status: RESOLVED WONTFIX
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-11-03 15:47 UTC by Pavol Klačanský
Modified: 2012-11-05 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replaced the typo KB should be kB (827 bytes, patch)
2012-11-04 18:18 UTC, Marc Ruiz - radykal - 		none Details | Review
Add a translator comment about 'KB' (1.45 KB, patch)
2012-11-05 13:28 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Pavol Klačanský 2012-11-03 15:47:03 UTC 
#: ../glib/gutils.c:2324
#, c-format
msgid "%.1f KB"

there should be "kB"
Comment 1 André Klapper 2012-11-04 16:46:43 UTC 
[Please actually MENTION the string in the bug summary.]
Comment 2 Pavol Klačanský 2012-11-04 17:02:11 UTC 
I mentioned it ;)
Comment 3 Marc Ruiz - radykal - 2012-11-04 18:18:31 UTC 
Created attachment 228040 [details] [review]
Replaced the typo KB should be kB
Comment 4 Matthias Clasen 2012-11-05 01:38:37 UTC 
Its not a typo: http://en.wikipedia.org/wiki/Kilobyte
Comment 5 Pavol Klačanský 2012-11-05 03:07:58 UTC 
why not? I do not see any contradicting reference in wiki
Comment 6 Emmanuele Bassi (:ebassi) 2012-11-05 12:18:34 UTC 
(In reply to comment #4)
> Its not a typo: http://en.wikipedia.org/wiki/Kilobyte

it is a typo: the correct prefix for 'kilobyte' is 'k', not 'K' - as the wiki page you linked says. :-)
Comment 7 Emmanuele Bassi (:ebassi) 2012-11-05 12:23:10 UTC 
the problem is that the function is question is broken by definition - hence why it's been deprecated and replaced by g_format_size().

at this point, it's pointless to fix the issue: the string is broken because the function itself is broken. I think WONTFIX is probably a better idea than NOTABUG. a warning in the function would also help avoiding new bugs being filed.
Comment 8 Allison Karlitskaya (desrt) 2012-11-05 13:28:48 UTC 
Created attachment 228108 [details] [review]
Add a translator comment about 'KB'

The GLib units policy used to be that 'KB' means 1024 bytes, 'MB' means
1024 KB, 'GB' means 1024 MB, etc.

Those days are over, but we have a deprecated function that still works
that way.  It contains the string "KB", marked for translation, which
has been a source of confusion for translators on multiple occasions.
Comment 9 Allison Karlitskaya (desrt) 2012-11-05 13:29:06 UTC 
Comment on attachment 228108 [details] [review]
Add a translator comment about 'KB'

Attachment 228108 [details] pushed as 81b27ff - Add a translator comment about 'KB'