GNOME Bugzilla – Bug 687416
Move DTMF plugin to -good
Last modified: 2013-03-09 01:22:54 UTC
Based on comment of ocrete in bug 687263 I also suggest the DTMF plugin is moved to good, it is needed for distributors to be able to ship empathy without a hard dependency on -bad.
Maybe someone can review it? Tests are also non-existent (although the Farstream test suite does some testing on it). I want to write tests using the GstTestClock on the other bug. Anyway, we can move it to -good now if you don't care.
GstTestClock is in core now, so you can use that in tests now. I'm not convinced tone_detect.c is suitably licensed for a move to -good. The code is only in the public domain: /* * DTMF Receiver module, part of: * BSD Telephony Of Mexico "Zapata" Telecom Library, version 1.10 12/9/01 * * Part of the "Zapata" Computer Telephony Technology. * * See http://www.bsdtelephony.com.mx * * * The technologies, software, hardware, designs, drawings, scheumatics, board * layouts and/or artwork, concepts, methodologies (including the use of all * of these, and that which is derived from the use of all of these), all other * intellectual properties contained herein, and all intellectual property * rights have been and shall continue to be expressly for the benefit of all * mankind, and are perpetually placed in the public domain, and may be used, * copied, and/or modified by anyone, in any manner, for any legal purpose, * without restriction. * * This module written by Stephen Underwood. */ /* tone_detect.c - General telephony tone detection, and specific detection of DTMF. Copyright (C) 2001 Steve Underwood <steveu@coppice.org> Despite my general liking of the GPL, I place this code in the public domain for the benefit of all mankind - even the slimy ones who might try to proprietize my work and use it to my detriment. */
Adding bug #607321 as dependency, because it looks API relevant so should be looked at before a move.
I'm not sure how "may be used, copied, and/or modified by anyone, in any manner, for any legal purpose, without restriction." isn't clear.
Public domain is as free as it can possibly be, it is even more free than BSD or MIT. So it shouldn't be a problem at all.
(In reply to comment #5) > Public domain is as free as it can possibly be, it is even more free than BSD > or MIT. So it shouldn't be a problem at all. See http://www.gnu.org/licenses/license-list.html#PublicDomain
Ok, I ended up reading on the Creative Commons site about putting things in the Public Domain and since some countries have laws about moral rights that more or less makes it impossible I will email Steve and ask if he can also release the code under the BSD license. He might feel this is a bit silly considering the code is in the public domain, but it removes any possible legal uncertainty there can be.
Whilst we're working on the license stuff, may I remind people that bug #607321 is a blocker for this as well, so if nothing is done to resolve it, this may not be moved this cycle.
There is an LGPL version of the same file inside libspansp, I'll move tone_detect to the spandsp plugin and remove it from the dtmf plugin..
The author said he's got an improved version that he'll make available under a BSD license rsn.
I moved dtmfdetect to the spandsp plugin and I use the version of the code that's in spandsp, so it's not our problem anymore. So apart from the lack of tests (although the Farstream test suite tests them), they're ready to move to -good.
> So apart from the lack of tests (although the Farstream test suite tests them), > they're ready to move to -good. Almost, see comment #3 and comment #8 :)
As for comment #3, I replied to that bug. For comment #8, I removed the offending code and instead move the element to the spandsp plugin which depends on libspandsp (which is the source of said code). There are also unit tests now for all 3 elements in the dtmf plugin. So I think we can move it !
commit c2446a70f65e5483327a6596eb28ee3a255ab0eb Author: Tim-Philipp Müller <tim@centricular.net> Date: Sat Mar 9 01:06:31 2013 +0000 Remove DTMF plugin, moved to -good https://bugzilla.gnome.org/show_bug.cgi?id=687416 commit 694dbcc5a01fb8f485d5a559df9d21e0597f043a Author: Tim-Philipp Müller <tim@centricular.net> Date: Sat Mar 9 01:18:30 2013 +0000 dtmf: move dtmf plugin from -bad to -good https://bugzilla.gnome.org/show_bug.cgi?id=687416