GNOME Bugzilla – Bug 687405
screen: preserve existing value
Last modified: 2013-07-16 17:00:36 UTC
Created attachment 227868 [details] [review] patch We should add the current value of the two delay settings on this panel to the choices offered in the combo boxes, if it is not one of the stock choices. Otherwise, you end up in a 'no way back' situation just by opening the combo box.
Review of attachment 227868 [details] [review]: But why? To get those custom values, you have to tweak those values by hand. We don't do this for any other drop-downs in control-center either (say, the text size in universal access).
Review of attachment 227868 [details] [review]: But why? To get those custom values, you have to tweak those values by hand. We don't do this for any other drop-downs in control-center either (say, the text size in universal access). ::: panels/screen/cc-screen-panel.c @@ +386,3 @@ + hours = minutes / 60; + minutes = minutes % 60; + s1 = g_strdup_printf (ngettext ("%d minute", "%d minutes", minutes), minutes); I have that same code in Totem, and I would really rather it landed in glib so we didn't have to copy/paste yet again)
I'm really not a fan of taking more of this human-readable formatting into glib - when we have done so in the past, we've been burned.
(In reply to comment #1) > To get those custom values, you have to tweak those values by hand. We don't do > this for any other drop-downs in control-center either (say, the text size in > universal access). Tempted to agree. Otherwise we have to range check for sanity and we'd get all kinds of odd bugs popping up.