After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687320 - configure.ac os_win32 is not initialized to no, breaks linux build
configure.ac os_win32 is not initialized to no, breaks linux build
Status: RESOLVED FIXED
Product: GUPnP
Classification: Other
Component: gupnp
0.19.x
Other Linux
: Normal major
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-01 06:47 UTC by Alban Browaeys
Modified: 2012-11-01 08:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
initialize os_win32 to "no" (658 bytes, patch)
2012-11-01 06:47 UTC, Alban Browaeys
committed Details | Review

Description Alban Browaeys 2012-11-01 06:47:32 UTC
Created attachment 227778 [details] [review]
initialize os_win32 to "no"

"if test "x$os_win32" = "xno"; then
    AC_ARG_WITH([context_manager],
            AS_HELP_STRING(
                        [--with-context-manager=@<:@network-manager/connman/unix/linux@:>@],
                        [Context Manager backend to use]),,
            [with_context_manager="none"])
else
    LIBGUPNP_LIBS="$LIBGUPNP_LIBS -lrpcrt4"
    with_context_manager="windows"
fi"

fails as os_win32 is not initialized to "no" so this test always fallback to win32 case.
Attached patch fix this.
Comment 1 Jens Georg 2012-11-01 08:56:01 UTC
Thanks. Seems to have been lost during rebasing.