After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687315 - various packaging fixes
various packaging fixes
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other All
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-01 03:46 UTC by Daiki Ueno
Modified: 2013-01-11 02:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: only export public symbols from the library (1.29 KB, patch)
2012-11-01 03:46 UTC, Daiki Ueno
committed Details | Review
build: make sure to define $datarootdir in generated scripts (1.21 KB, patch)
2012-11-01 03:46 UTC, Daiki Ueno
committed Details | Review
build: suppress Python bytecode generation when building (2.55 KB, patch)
2012-11-01 03:46 UTC, Daiki Ueno
committed Details | Review
build: install vapi file (1.91 KB, patch)
2012-11-01 03:46 UTC, Daiki Ueno
committed Details | Review
build: install pkg-config file (1.81 KB, patch)
2012-11-01 03:46 UTC, Daiki Ueno
committed Details | Review
build: use git.mk (15.18 KB, patch)
2012-11-01 03:46 UTC, Daiki Ueno
committed Details | Review
Don't use deprecated Automake variable INCLUDE. (1.03 KB, patch)
2012-12-30 05:01 UTC, Daiki Ueno
committed Details | Review
build: rename caribou.pc to caribou-1.0.pc (1.80 KB, patch)
2013-01-06 01:48 UTC, Daiki Ueno
committed Details | Review

Description Daiki Ueno 2012-11-01 03:46:07 UTC
Here is a set of patches that will make the packaging a bit sane.
Comment 1 Daiki Ueno 2012-11-01 03:46:09 UTC
Created attachment 227770 [details] [review]
build: only export public symbols from the library
Comment 2 Daiki Ueno 2012-11-01 03:46:12 UTC
Created attachment 227771 [details] [review]
build: make sure to define $datarootdir in generated scripts

Some of automake standard directory variables are expanded using
"${datarootdir}", which must be available at run-time.  Define it
at the beginning of the script templates.
Comment 3 Daiki Ueno 2012-11-01 03:46:15 UTC
Created attachment 227772 [details] [review]
build: suppress Python bytecode generation when building
Comment 4 Daiki Ueno 2012-11-01 03:46:18 UTC
Created attachment 227773 [details] [review]
build: install vapi file

Install caribou-1.0.vapi into the standard vapi directory.  Also
install caribou-1.0.deps file so "--pkg caribou-1.0" automatically
pulls dependencies.
Comment 5 Daiki Ueno 2012-11-01 03:46:22 UTC
Created attachment 227774 [details] [review]
build: install pkg-config file
Comment 6 Daiki Ueno 2012-11-01 03:46:25 UTC
Created attachment 227775 [details] [review]
build: use git.mk

Use git.mk to generate .gitignore files upon building.
Also remove *.[ch] from CLEANFILES since it makes little sense
with automake Vala support.
Comment 7 Daiki Ueno 2012-12-30 05:01:55 UTC
Created attachment 232384 [details] [review]
Don't use deprecated Automake variable INCLUDE.
Comment 8 Daiki Ueno 2012-12-30 05:27:55 UTC
Pushed since they are all minor...

Attachment 227770 [details] pushed as a6a4392 - build: only export public symbols from the library
Attachment 227771 [details] pushed as 86fdbc3 - build: make sure to define $datarootdir in generated scripts
Attachment 227772 [details] pushed as 662e04e - build: suppress Python bytecode generation when building
Attachment 227773 [details] pushed as 11b35f6 - build: install vapi file
Attachment 227774 [details] pushed as 9c6e23a - build: install pkg-config file
Attachment 227775 [details] pushed as 4e2469f - build: use git.mk
Comment 9 Daiki Ueno 2013-01-06 01:48:28 UTC
Created attachment 232841 [details] [review]
build: rename caribou.pc to caribou-1.0.pc

Both *.pc and *.vapi should have the same basename.  Also remove *.pc
on "make distclean" instead of "make clean" since it is created at
configure time.
--
Minor amendment to comment 5.
Comment 10 Daiki Ueno 2013-01-11 02:37:05 UTC
Comment on attachment 232841 [details] [review]
build: rename caribou.pc to caribou-1.0.pc

Attachment 232841 [details] pushed as 4a9bda2 - build: rename caribou.pc to caribou-1.0.pc