After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687232 - Wrong window geometry after going to A11y panel
Wrong window geometry after going to A11y panel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-30 22:37 UTC by Giovanni Campagna
Modified: 2012-11-02 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove previous panel widget when switching to a new one (1.04 KB, patch)
2012-10-30 22:50 UTC, Giovanni Campagna 		rejected Details | Review
Remove previous panel widget when switching to a new one (1.49 KB, patch)
2012-11-02 15:48 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-10-30 22:37:24 UTC 
If you go to the hearing tab of a11y, and from there you jump to sound, when going back to the overview g-c-c gets confused and keeps the window higher than it should be.
It's easy to notice the brokenness by looking at the background panel.

This is with GNOME_CONTROL_CENTER_3_7_1-3-g7409591
Comment 1 Giovanni Campagna 2012-10-30 22:50:03 UTC 
Created attachment 227695 [details] [review]
Remove previous panel widget when switching to a new one

If we don't remove it, it intereferes with the layout of the new panel
and cause weird overallocation effects.
Comment 2 Bastien Nocera 2012-10-31 16:50:22 UTC 
Review of attachment 227695 [details] [review]:

No. Check the code there, and the history as well, we want to keep the old panel for as long as possible.
Comment 3 Thomas Wood 2012-11-01 13:56:09 UTC 
Currently, if you go back to the overview mode from a panel, the panel is removed from the notebook, causing it to be destroyed. If you go to a panel and then jump to another panel, only the last panel is removed when going back to the overview mode. The patch appears to remove this inconsistency.
Comment 4 Giovanni Campagna 2012-11-02 14:50:23 UTC 
(In reply to comment #2)
> Review of attachment 227695 [details] [review]:
> 
> No. Check the code there, and the history as well, we want to keep the old
> panel for as long as possible.

Maybe I didn't check hard enough, but the code is not clear why we should keep the panel there, and neither is the history (looking at commit messages only)
Comment 5 Bastien Nocera 2012-11-02 15:07:21 UTC 
We don't want to nuke the old panel until the new one is actually created (it doesn't need to have been packed in the shell itself though), so that invalid panel names, or broken panels don't cause panel switches that wouldn't work.
Comment 6 Giovanni Campagna 2012-11-02 15:48:15 UTC 
Created attachment 227906 [details] [review]
Remove previous panel widget when switching to a new one

If we don't remove it, it intereferes with the layout of the new panel
and cause weird overallocation effects.
Comment 7 Bastien Nocera 2012-11-02 16:28:03 UTC 
See also the additional patch I committed, to avoid the old panel being thrown away if we can't load the new one.

Attachment 227906 [details] pushed as e178a20 - Remove previous panel widget when switching to a new one