After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687207 - Add logo for RHEL 4.x, 5.x and 6.x
Add logo for RHEL 4.x, 5.x and 6.x
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-10-30 15:26 UTC by Zeeshan Ali
Modified: 2016-03-31 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add logo for RHEL 4.x, 5.x and 6.x (2.60 KB, patch)
2012-10-30 15:26 UTC, Zeeshan Ali 		reviewed Details | Review
Update GNOME logo URL (899 bytes, patch)
2012-10-30 17:28 UTC, Zeeshan Ali 		committed Details | Review
Add logo for RHEL 4.x, 5.x and 6.x (2.60 KB, patch)
2012-10-30 17:28 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-10-30 15:26:21 UTC 
See patch
Comment 1 Zeeshan Ali 2012-10-30 15:26:23 UTC 
Created attachment 227647 [details] [review]
Add logo for RHEL 4.x, 5.x and 6.x

This logo file was specifically created by our designer, Jakub Steiner
<jimmac@gmail.com> for Boxes.
Comment 2 Christophe Fergeau 2012-10-30 15:46:29 UTC 
Review of attachment 227647 [details] [review]:

Ah good job for getting permission to use this!
Patch looks good, my only grief is the "This logo file was specifically created by our designer, Jakub Steiner
<jimmac@gmail.com> for Boxes." which is misleading, I understand this as "Jimmac drew the logo from scratch" which is probably not what he did. ACK with that clarified.
Comment 3 Zeeshan Ali 2012-10-30 16:33:21 UTC 
(In reply to comment #2)
> Review of attachment 227647 [details] [review]:
> 
> Ah good job for getting permission to use this!

Thanks. :)

> Patch looks good, my only grief is the "This logo file was specifically created
> by our designer, Jakub Steiner
> <jimmac@gmail.com> for Boxes." which is misleading, I understand this as
> "Jimmac drew the logo from scratch" which is probably not what he did. ACK with
> that clarified.

No, he didn't. How should I word it? The source image is behind an authentication wall so I wouldn't want to link to that.
Comment 4 Christophe Fergeau 2012-10-30 16:46:46 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Patch looks good, my only grief is the "This logo file was specifically created
> > by our designer, Jakub Steiner
> > <jimmac@gmail.com> for Boxes." which is misleading, I understand this as
> > "Jimmac drew the logo from scratch" which is probably not what he did. ACK with
> > that clarified.
> 
> No, he didn't. How should I word it? The source image is behind an
> authentication wall so I wouldn't want to link to that.

Not sure what he had to do exactly to make the logo usable by us? just transparency/background/size changes I guess? "Thanks to Jakub.... .com> for adjusting XXX to make the logo fit better in Boxes UI" ?
Comment 5 Zeeshan Ali 2012-10-30 17:28:03 UTC 
Created attachment 227661 [details] [review]
Update GNOME logo URL

Logo moved to a more canonical location. A link is provided at the older
location so nothing should break for existing releases of Boxes.
Comment 6 Zeeshan Ali 2012-10-30 17:28:25 UTC 
Created attachment 227662 [details] [review]
Add logo for RHEL 4.x, 5.x and 6.x

v2: Updated description as per review.
Comment 7 Christophe Fergeau 2012-10-31 09:51:56 UTC 
Review of attachment 227661 [details] [review]:

ueao
Comment 8 Christophe Fergeau 2012-10-31 09:52:26 UTC 
Review of attachment 227662 [details] [review]:

eou
Comment 9 Zeeshan Ali 2012-10-31 17:08:56 UTC 
Attachment 227661 [details] pushed as 826d503 - Update GNOME logo URL
Attachment 227662 [details] pushed as 3f1041a - Add logo for RHEL 4.x, 5.x and 6.x