Bug 687204 – about dialog segfault

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 687204 - about dialog segfault


Summary:	about dialog segfault


Status:	RESOLVED FIXED

Product:	baobab
Classification:	Core
Component:	general
Version:	3.6.x
Hardware:	Other OpenBSD

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Baobab Maintainers
QA Contact:	Baobab Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-10-30 15:14 UTC by Antoine Jacoutot
Modified:	2012-11-10 15:40 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
end the authors list with null, otherwise the about dialog segfaults (1.02 KB, patch) 2012-11-05 17:47 UTC, Sebastien Bacher	accepted-commit_now	Details \| Review

Description Antoine Jacoutot 2012-10-30 15:14:50 UTC

Hi.

I'm getting a segfault when navigating to Help / About.

(gdb) run
Starting program: /usr/local/bin/baobab 

Program received signal SIGSEGV, Segmentation fault.
0x000011ff40c76f12 in strlen (str=0xf9 <Address 0xf9 out of bounds>) at /usr/src/lib/libc/string/strlen.c:43
43              for (s = str; *s; ++s)
(gdb) bt full

+ Trace 231111

#0 strlen
at /usr/src/lib/libc/string/strlen.c line 43
#0 strlen
at /usr/src/lib/libc/string/strlen.c line 43
#1 g_strdup
at gstrfuncs.c line 363
#2 g_strdupv
at gstrfuncs.c line 2439
#3 _g_type_boxed_copy
at gtype.c line 4237
#4 boxed_proxy_collect_value
at gboxed.c line 230
#5 g_object_set_valist
at gobject.c line 1942
#6 gtk_show_about_dialog
from /usr/local/lib/libgtk-3.so.600.0
#7 baobab_window_on_about_activate
at baobab-window.c line 1158
#8 _baobab_window_on_about_activate_gsimple_action_activate_callback
at baobab-window.c line 441
#9 g_cclosure_marshal_VOID__VARIANT
at gmarshal.c line 1350
#10 g_closure_invoke
at gclosure.c line 777
#11 signal_emit_unlocked_R
at gsignal.c line 3551
#12 g_signal_emit_valist
at gsignal.c line 3300
#13 g_signal_emit
at gsignal.c line 3356
#14 g_simple_action_activate
at gsimpleaction.c line 204
#15 g_action_activate
at gaction.c line 386
#16 g_simple_action_group_activate
at gsimpleactiongroup.c line 136
#17 g_action_group_activate_action
at gactiongroup.c line 589
#18 g_action_muxer_new
from /usr/local/lib/libgtk-3.so.600.0
#19 g_action_group_activate_action
at gactiongroup.c line 589
#20 g_action_muxer_new
from /usr/local/lib/libgtk-3.so.600.0
#21 g_action_group_activate_action
#22 g_action_muxer_new
from /usr/local/lib/libgtk-3.so.600.0
#23 g_action_group_activate_action
at gactiongroup.c line 589
#24 g_action_muxer_new
from /usr/local/lib/libgtk-3.so.600.0
#25 g_action_group_activate_action
at gactiongroup.c line 589
#26 g_action_muxer_new
from /usr/local/lib/libgtk-3.so.600.0
#27 g_action_group_activate_action
at gactiongroup.c line 589
#28 gtk_menu_item_new
from /usr/local/lib/libgtk-3.so.600.0
#29 gtk_check_menu_item_toggled
from /usr/local/lib/libgtk-3.so.600.0
#30 g_cclosure_marshal_VOID__VOIDv
at gmarshal.c line 115
#31 g_type_class_meta_marshalv
at gclosure.c line 997
#32 _g_closure_invoke_va
at gclosure.c line 840
#33 g_signal_emit_valist
at gsignal.c line 3211
#34 g_signal_emit
at gsignal.c line 3356
#35 gtk_widget_activate
from /usr/local/lib/libgtk-3.so.600.0
#36 gtk_menu_shell_activate_item
from /usr/local/lib/libgtk-3.so.600.0
#37 gtk_menu_shell_append
from /usr/local/lib/libgtk-3.so.600.0
#38 gtk_init_with_args
from /usr/local/lib/libgtk-3.so.600.0
#39 g_type_class_meta_marshalv
at gclosure.c line 997
#40 _g_closure_invoke_va
at gclosure.c line 840
#41 g_signal_emit_valist
at gsignal.c line 3211
#42 g_signal_emit
at gsignal.c line 3356
#43 gtk_widget_set_events
from /usr/local/lib/libgtk-3.so.600.0
#44 gtk_false
from /usr/local/lib/libgtk-3.so.600.0
#45 gtk_main_do_event
from /usr/local/lib/libgtk-3.so.600.0
#46 gdk_drag_action_get_type
from /usr/local/lib/libgdk-3.so.600.0
#47 g_main_dispatch
at gmain.c line 2715
#48 g_main_context_dispatch
at gmain.c line 3219
#49 g_main_context_iterate
at gmain.c line 3290
#50 g_main_context_iteration
at gmain.c line 3351
#51 g_application_run
at gapplication.c line 1624
#52 _vala_main
at main.c line 67
#53 main
at main.c line 76

Comment 1 Sebastien Bacher 2012-11-05 17:47:00 UTC

Created attachment 228166 [details] [review]
end the authors list with null, otherwise the about dialog segfaults

Comment 2 Paolo Borelli 2012-11-05 17:50:37 UTC

Review of attachment 228166 [details] [review]:

Ouch! good catch.... weird it does not happen here.

I will release a .2 later tonight

Comment 3 Antoine Jacoutot 2012-11-06 07:13:41 UTC

Just adding my vote that this patch does fix the segfault, thank you.

Comment 4 Paolo Borelli 2012-11-10 15:40:14 UTC

Pushed the patch to master and gnome-3-6 and released 3.6.3. Thanks!