After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687067 - [patches] wip/modernize
[patches] wip/modernize
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-28 21:54 UTC by Colin Walters
Modified: 2012-11-02 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Require the latest GLib (1.25 KB, patch)
2012-10-28 21:54 UTC, Colin Walters 		committed Details | Review
Use g_unix_signal_add() instead of GdmSignalHandler (26.50 KB, patch)
2012-10-28 21:54 UTC, Colin Walters 		committed Details | Review
Use g_clear_object/g_clear_pointer (13.98 KB, patch)
2012-10-28 21:54 UTC, Colin Walters 		committed Details | Review
Drop gsm-marshal.list, use g_cclosure_marshal_generic (18.66 KB, patch)
2012-10-28 21:54 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-10-28 21:54:00 UTC 
Various patches to bring gnome-session up to speed on the latest GLib.
Comment 1 Colin Walters 2012-10-28 21:54:02 UTC 
Created attachment 227485 [details] [review]
build: Require the latest GLib

Needed to use SIGUSR1 with g_unix_signal_add().
Comment 2 Colin Walters 2012-10-28 21:54:04 UTC 
Created attachment 227486 [details] [review]
Use g_unix_signal_add() instead of GdmSignalHandler

Part of GLib, cleaner, better, faster, reverses male pattern baldness,
etc.
Comment 3 Colin Walters 2012-10-28 21:54:06 UTC 
Created attachment 227487 [details] [review]
Use g_clear_object/g_clear_pointer

Just makes the code feel more modern.
Comment 4 Colin Walters 2012-10-28 21:54:09 UTC 
Created attachment 227488 [details] [review]
Drop gsm-marshal.list, use g_cclosure_marshal_generic

We can just pass NULL everywhere nowadays.
Comment 5 Matthias Clasen 2012-10-29 00:40:55 UTC 
Review of attachment 227485 [details] [review]:

Sure
Comment 6 Matthias Clasen 2012-10-29 00:41:49 UTC 
Review of attachment 227486 [details] [review]:

Looks nice - we should do the same to gdm, where this code originated
Comment 7 Matthias Clasen 2012-10-29 00:43:16 UTC 
Review of attachment 227487 [details] [review]:

Looks good
Comment 8 Matthias Clasen 2012-10-29 00:43:58 UTC 
Review of attachment 227488 [details] [review]:

Ok
Comment 9 Colin Walters 2012-11-02 20:38:02 UTC 
Attachment 227485 [details] pushed as 436bb15 - build: Require the latest GLib
Attachment 227486 [details] pushed as 76c7543 - Use g_unix_signal_add() instead of GdmSignalHandler
Attachment 227487 [details] pushed as 655d9bd - Use g_clear_object/g_clear_pointer
Attachment 227488 [details] pushed as 06c7065 - Drop gsm-marshal.list, use g_cclosure_marshal_generic