After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687051 - Correctly marshal Google system groups from outside
Correctly marshal Google system groups from outside
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks: 687050
 
 
Reported: 2012-10-28 17:37 UTC by Giovanni Campagna
Modified: 2012-11-06 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Google: allow writing X-GOOGLE-SYSTEM-GROUP-IDS (3.55 KB, patch)
2012-10-28 17:38 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-10-28 17:37:52 UTC 
The google addressbook backend currently converts system groups into a custom X-GOOGLE-SYSTEM-GROUP-IDS VCard attribute. The problem is, if you attempt setting this attribute in an existing EContact, instead of correctly changing the group membership, you end up with an extended property with that name.

This is needed to fix bug 687050 in folks.
Comment 1 Giovanni Campagna 2012-10-28 17:38:31 UTC 
Created attachment 227463 [details] [review]
Google: allow writing X-GOOGLE-SYSTEM-GROUP-IDS

We expose GData system groups as an extended attribute with that
name, but if we found it in the EContact we would turn it into
an extended property. Instead, marshal the system group IDs into
Evolution categories, and then those into GData groups or system
groups.
Comment 2 Philip Withnall 2012-11-06 08:40:39 UTC 
Review of attachment 227463 [details] [review]:

Looks good to me. Please commit.
Comment 3 Giovanni Campagna 2012-11-06 18:32:41 UTC 
Attachment 227463 [details] pushed as f7da599 - Google: allow writing X-GOOGLE-SYSTEM-GROUP-IDS