GNOME Bugzilla – Bug 687049
Add to My Contacts creates duplicate contacts
Last modified: 2013-03-21 10:44:50 UTC
If you click on Add to My Contacts from a Google Other contact, you end up with a duplicate "holder" contact, whose only purpose is to keep linkable properties. What's worse, the other contact is still a separate persona, so the view just changes from "Add to My Contacts" to "Unlink", with all the details still under the Other Contacts. While this makes sense once you understand the folks implementation details, it is definitely weird from the user POV. Instead, I think gnome-contacts should change the appropriate details in the Google persona directly.
Created attachment 227465 [details] [review] Contacts: fix changing a Google Other contact into a My Contact Previously, clicking on the Add to My Contacts button for a Google Other contact would attempt a link operation with nothing, that would end up creating a new scratch contact to link into, which by chance would also have the magic in-google-personal-group bit set. Instead, use the new API in Folks to change it directly, to avoid creating a duplicate contact.
Created attachment 227466 [details] [review] Squash a critical warning when the application is closed. Destroying the EggListBox will emit child-selected with a null child.
Attachment 227465 [details] pushed as 1b03e01 - Contacts: fix changing a Google Other contact into a My Contact Attachment 227466 [details] pushed as 4b5ffd3 - Squash a critical warning when the application is closed.
reverted this and applied it again on master after having branched for 3.6 first, as we need a new eds for it to work.
We don't have the concept of "My Contacts" any more. Closing as obsolete.