After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686976 - Add support for the new OPUS codec
Add support for the new OPUS codec
Status: RESOLVED FIXED
Product: taglib-sharp
Classification: Other
Component: General
unspecified
Other Windows
: Normal enhancement
: ---
Assigned To: taglib-sharp-maint
taglib-sharp-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-27 11:21 UTC by Bernd Niedergesaess
Modified: 2016-01-09 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adds support for Opus MIME types and codec (13.28 KB, patch)
2015-12-08 13:41 UTC, Les De Ridder 		none Details | Review
Adds tests for Opus (3.73 KB, patch)
2015-12-13 21:30 UTC, Les De Ridder 		none Details | Review
Opus test sample (91.15 KB, audio/ogg)
2015-12-13 21:30 UTC, Les De Ridder 		  Details
Adds support, tests, and sample for Opus (132.73 KB, patch)
2015-12-16 09:20 UTC, Les De Ridder 		none Details | Review

Description Bernd Niedergesaess 2012-10-27 11:21:02 UTC 
It would be great if you could add support for the OPUS audio codec.
More info here:
http://www.opus-codec.org/

The meta data is basically based on the OGG format.
Comment 1 Les De Ridder 2015-12-07 16:51:15 UTC 
I implemented this and made a pull request on GitHub.

Pull request: https://github.com/mono/taglib-sharp/pull/27
Comment 2 Les De Ridder 2015-12-08 13:41:27 UTC 
Created attachment 316939 [details] [review]
Adds support for Opus MIME types and codec

Patch file added as requested.
Comment 3 Andrés G. Aragoneses (IRC: knocte) 2015-12-08 13:55:40 UTC 
Thanks very much! Do you mind adding new unit test(s) for this?
Comment 4 Les De Ridder 2015-12-09 13:08:45 UTC 
I don't mind adding unit tests, but the existing tests are container-based, not codec-based. For example the Ogg tests just test the Ogg format itself (with an Ogg Vorbis sample file), but another codec, Ogg Theora, doesn't have its own tests. The same is true for other containers and codecs.

While refactoring the existing tests and adding codec-based tests could be useful for some header oddities, I think this is outside the scope of this bug.
Comment 5 Andrés G. Aragoneses (IRC: knocte) 2015-12-12 05:43:10 UTC 
(In reply to Les De Ridder from comment #4)
> While refactoring the existing tests and adding codec-based tests could be
> useful for some header oddities, I think this is outside the scope of this
> bug.

Yes.

Just place an opus test with the smallest opus binary file you can come up with. And make it as you please (codec based or container based).

Then if you have time, you can refactor the existing tests and propose a patch in a new bug. Thanks
Comment 6 Les De Ridder 2015-12-13 21:30:02 UTC 
Created attachment 317315 [details] [review]
Adds tests for Opus

Added tests for Opus files.
Comment 7 Les De Ridder 2015-12-13 21:30:29 UTC 
Created attachment 317316 [details]
Opus test sample
Comment 8 Andrés G. Aragoneses (IRC: knocte) 2015-12-16 08:02:40 UTC 
Thanks for your work. Can you please merge all 3 attachments in just one patch? Thanks
Comment 9 Les De Ridder 2015-12-16 09:20:47 UTC 
Created attachment 317481 [details] [review]
Adds support, tests, and sample for Opus

Patch file containing all of the above.