GNOME Bugzilla – Bug 686944
Overview - unmaximized windows can be taller than maximized ones
Last modified: 2013-01-24 20:20:11 UTC
Created attachment 227361 [details] screenshot See the screenshot - the non-maximized window is taller than the maximized one.
Created attachment 227385 [details] [review] workspace: Use a better algorithm for computing individual thumbnail scale The one we had before could make unmaximized windows appear to be bigger than maximized ones, for a few reasons. Ensure that this doesn't happen again, and add some comments to explain the whys and needs for twiddling the individual thumbnail size.
Created attachment 227435 [details] [review] workspace: Use a better algorithm for computing individual thumbnail scale The one we had before could make unmaximized windows appear to be bigger than maximized ones, for a few reasons. Ensure that this doesn't happen again, and add some comments to explain the whys and needs for twiddling the individual thumbnail size. This should fix some weird issues with the overview some people were having.
Created attachment 227436 [details] [review] workspace: Clamp individual maximized scales to WINDOW_CLONE_MAXIMUM_SCALE We clamp the overall layout's scale to WINDOW_CLONE_MAXIMUM_SCALE, but since we do a bit of tweaking to try and make super small windows a tad larger, it's theoretically possible that windows may become larger than the proper maximum scale. Fix this issue. Seems I forgot to attach both patches.
Created attachment 227437 [details] [review] workspace: Use a better algorithm for computing individual thumbnail scale The one we had before could make unmaximized windows appear to be bigger than maximized ones, for a few reasons. Ensure that this doesn't happen again, and add some comments to explain the whys and needs for twiddling the individual thumbnail size.
Florian, can you review this one?
Ping again? This would be nice for 3.6.2
Uh? The patches are based on the 3.7 overview layout changes, so how is that relevant for 3.6.2?
Oh, I thought I landed the overview relayout for the gnome-3-6 branch, but I guess I was mistaken.
I am still seeing this bug. The attached patches seem to successfully resolve the issue.
Review of attachment 227436 [details] [review]: [ Jasper asked me to take a look at these ] I don't really understand why you can't limit the scale to its maximum value unconditionally. ::: js/ui/workspace.js @@ +720,2 @@ // base scale, @scale. + _computeWindowScale: function(window) { The scale argument shouldn't be removed here. @@ +815,3 @@ + s = Math.min(s, WINDOW_CLONE_MAXIMUM_SCALE); + let width = window.actor.width * s; + let height = window.actor.height * s; I don't think returning a single value from _computeWindowScale() makes the code particularly cleaner here. Can't you do the Math.min() inside _computeWindowScale() directly?
Review of attachment 227437 [details] [review]: LGTM
Ping
Attachment 227436 [details] pushed as 7ba0f07 - workspace: Clamp individual maximized scales to WINDOW_CLONE_MAXIMUM_SCALE Attachment 227437 [details] pushed as ef69c22 - workspace: Use a better algorithm for computing individual thumbnail scale