After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686941 - Overlaid toolbar buttons are unclear
Overlaid toolbar buttons are unclear
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.6.x
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
: 686883 (view as bug list)
Depends on:
Blocks: 686781
 
 
Reported: 2012-10-26 12:05 UTC by Allan Day
Modified: 2016-03-31 13:54 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
Use labels in OSD toolbar (1.57 KB, patch)
2013-01-28 13:34 UTC, Alexander Larsson 		committed Details | Review
screenshot of patched toolbar (248.72 KB, image/png)
2013-01-28 13:34 UTC, Alexander Larsson 		  Details

Description Allan Day 2012-10-26 12:05:14 UTC 
When you enter selection mode and select a box, a toolbar pops up with a bunch of buttons. The function of some of these buttons is unclear. The worst one is the button to delete the box. The icon isn't clear, but it looks like it could be destructive - that's an unnerving situation to put a user in.

My personal view is that we should be using text labels for these buttons rather than icons. Many of the actions are going to be very difficult to convey with icons alone (eg. "Add to Collection"). However, that would require that we change the design pattern for these overlaid toolbars. Jon - what do you think?
Comment 1 Jakub Steiner 2012-10-26 12:53:04 UTC 
I am in favor of using labels.
Comment 2 Alexander Larsson 2013-01-28 13:34:03 UTC 
Created attachment 234614 [details] [review]
Use labels in OSD toolbar
Comment 3 Alexander Larsson 2013-01-28 13:34:54 UTC 
Created attachment 234615 [details]
screenshot of patched toolbar

This is what the patch looks like. Is this what you wanted?
Comment 4 Alexander Larsson 2013-01-28 14:03:26 UTC 
Looks good according to jimmac, anyone want to review the patch?
Comment 5 Alexander Larsson 2013-01-28 14:53:04 UTC 
*** Bug 686883 has been marked as a duplicate of this bug. ***
Comment 6 Zeeshan Ali 2013-01-28 19:35:35 UTC 
Review of attachment 234614 [details] [review]:

ACK though you want to update version unless we want to backport.
Comment 7 Alexander Larsson 2013-01-29 08:40:48 UTC 
Attachment 234614 [details] pushed as ee408de - Use labels in OSD toolbar