After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686940 - Properties view - clicking on the thumbnail should switch to the box
Properties view - clicking on the thumbnail should switch to the box
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: properties
3.6.x
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-10-26 11:59 UTC by Allan Day
Modified: 2016-03-31 13:56 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6


Attachments
properties: go back to display when clicking thumbnail (1.02 KB, patch)
2012-10-27 00:20 UTC, Marc-Andre Lureau
needs-work Details | Review
properties: go back to display when clicking thumbnail (1.06 KB, patch)
2012-10-29 16:28 UTC, Marc-Andre Lureau
committed Details | Review

Description Allan Day 2012-10-26 11:59:38 UTC
You usually expect a thumbnail to open the item when it is selected. I did, but nothing happened when I clicked on it.
Comment 1 Zeeshan Ali 2012-10-26 14:36:05 UTC
(In reply to comment #0)
> You usually expect a thumbnail to open the item when it is selected. I did, but
> nothing happened when I clicked on it.

Thats weird, we immediately bring it to middle while starting/connecting to the box.
Comment 2 Matthias Clasen 2012-10-26 23:50:53 UTC
I agree, I constantly click on the thumbnail in the properties view, expecting it to open up
Comment 3 Marc-Andre Lureau 2012-10-27 00:20:39 UTC
Created attachment 227390 [details] [review]
properties: go back to display when clicking thumbnail
Comment 4 Zeeshan Ali 2012-10-29 14:47:18 UTC
Ouch, I totally missed the context. :)
Comment 5 Zeeshan Ali 2012-10-29 14:52:13 UTC
Review of attachment 227390 [details] [review]:

::: src/machine.vala
@@ +562,3 @@
         if (ui_state == UIState.PROPERTIES) {
             display = new GtkClutter.Actor.with_contents (widget);
+            display.button_release_event.connect (() => {

we need to track button press event as well. With this patch, we go back to display state even if button was pressed outside the thumbnail and then release on the thumbnail. I suspect its a corner case but it'll still look bad if user somehow does that.
Comment 6 Marc-Andre Lureau 2012-10-29 16:16:45 UTC
(In reply to comment #5)
> we need to track button press event as well. With this patch, we go back to
> display state even if button was pressed outside the thumbnail and then release
> on the thumbnail. I suspect its a corner case but it'll still look bad if user
> somehow does that.

There is ClutterAction for that, will rework the patch.
Comment 7 Marc-Andre Lureau 2012-10-29 16:28:53 UTC
Created attachment 227555 [details] [review]
properties: go back to display when clicking thumbnail
Comment 8 Zeeshan Ali 2012-10-29 21:25:42 UTC
Review of attachment 227555 [details] [review]:

ACK

::: src/machine.vala
@@ +566,3 @@
+            click.clicked.connect (() => {
+                App.app.ui_state = Boxes.UIState.DISPLAY;
+            });

interesting! Shouldn't we be using the same in collection-view as well?
Comment 9 Zeeshan Ali 2012-10-29 21:28:56 UTC
Review of attachment 227555 [details] [review]:

::: src/machine.vala
@@ +566,3 @@
+            click.clicked.connect (() => {
+                App.app.ui_state = Boxes.UIState.DISPLAY;
+            });

NM that, just realized there is no actor in there. :)
Comment 10 Marc-Andre Lureau 2012-10-30 18:51:55 UTC
Attachment 227555 [details] pushed as 2c19ae7 - properties: go back to display when clicking thumbnail