GNOME Bugzilla – Bug 686940
Properties view - clicking on the thumbnail should switch to the box
Last modified: 2016-03-31 13:56:35 UTC
You usually expect a thumbnail to open the item when it is selected. I did, but nothing happened when I clicked on it.
(In reply to comment #0) > You usually expect a thumbnail to open the item when it is selected. I did, but > nothing happened when I clicked on it. Thats weird, we immediately bring it to middle while starting/connecting to the box.
I agree, I constantly click on the thumbnail in the properties view, expecting it to open up
Created attachment 227390 [details] [review] properties: go back to display when clicking thumbnail
Ouch, I totally missed the context. :)
Review of attachment 227390 [details] [review]: ::: src/machine.vala @@ +562,3 @@ if (ui_state == UIState.PROPERTIES) { display = new GtkClutter.Actor.with_contents (widget); + display.button_release_event.connect (() => { we need to track button press event as well. With this patch, we go back to display state even if button was pressed outside the thumbnail and then release on the thumbnail. I suspect its a corner case but it'll still look bad if user somehow does that.
(In reply to comment #5) > we need to track button press event as well. With this patch, we go back to > display state even if button was pressed outside the thumbnail and then release > on the thumbnail. I suspect its a corner case but it'll still look bad if user > somehow does that. There is ClutterAction for that, will rework the patch.
Created attachment 227555 [details] [review] properties: go back to display when clicking thumbnail
Review of attachment 227555 [details] [review]: ACK ::: src/machine.vala @@ +566,3 @@ + click.clicked.connect (() => { + App.app.ui_state = Boxes.UIState.DISPLAY; + }); interesting! Shouldn't we be using the same in collection-view as well?
Review of attachment 227555 [details] [review]: ::: src/machine.vala @@ +566,3 @@ + click.clicked.connect (() => { + App.app.ui_state = Boxes.UIState.DISPLAY; + }); NM that, just realized there is no actor in there. :)
Attachment 227555 [details] pushed as 2c19ae7 - properties: go back to display when clicking thumbnail