After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686885 - wl_egl_pixmap is not in wayland anymore
wl_egl_pixmap is not in wayland anymore
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other Linux
: Normal blocker
: ---
Assigned To: gtk-bugs
gtk-bugs
: 688534 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-25 19:08 UTC by Hristo Venev
Modified: 2013-01-23 15:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to drop Waylang EGL pixmaps usage (3.24 KB, patch)
2012-11-28 13:02 UTC, Quentin "Sardem FF7" Glidic
none Details | Review

Description Hristo Venev 2012-10-25 19:08:26 UTC
Warnings:
gdkwindow-wayland.c: In function 'gdk_wayland_create_cairo_surface':
gdkwindow-wayland.c:405:3: warning: implicit declaration of function 'wl_egl_pixmap_create' [-Wimplicit-function-declaration]
gdkwindow-wayland.c:405:16: warning: assignment makes pointer from integer without a cast [enabled by default]
gdkwindow-wayland.c:433:7: warning: implicit declaration of function 'wl_egl_pixmap_create_buffer' [-Wimplicit-function-declaration]
gdkwindow-wayland.c:432:18: warning: assignment makes pointer from integer without a cast [enabled by default]

In commits e20a0f14b5fdbff9afa5d0d6ee35de8728f6a200 of mesa and 009d452432dd3550d2db0d931dc39769939f3ddf of wayland, wl_egl_pixmap and friends were dropped because they were said to be ill-defined.
Commit message:

    wayland-egl: Drop ill-defined pixmap support
    
    We don't have a use case for this and the actual semantics and
    synchronization behavior of wl_egl_pixmap were never really well-defined.
    It also doesn't provide the cross-process buffer sharing that make
    window systems pixmaps useful in other window systems.

As of now's git this bug it's not fixed.
Comment 1 Hristo Venev 2012-10-31 16:41:03 UTC
Still broken.
Comment 2 Quentin "Sardem FF7" Glidic 2012-11-28 13:02:49 UTC
Created attachment 230083 [details] [review]
Patch to drop Waylang EGL pixmaps usage

Applying this patch, the backend compiles and run. Nothing visible in Weston though.
Comment 3 Armin K. 2012-12-23 22:19:03 UTC
Only happens when --enable-wayland-cairo-gl is passed to configure options. Still present in latest git master.
Comment 4 Rob Bradford 2013-01-23 15:34:21 UTC
Hi all, thanks for comments on this bug. I've removed the code from GDK and also have removed the configure option. When we have more stability around cairo-gl and appropriate API in the Wayland client library then we could start to reintroduce this functionality.
Comment 5 Rob Bradford 2013-01-23 15:38:40 UTC
*** Bug 688534 has been marked as a duplicate of this bug. ***