After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686837 - imagefreeze: improve caps negotiation
imagefreeze: improve caps negotiation
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other All
: Normal normal
: 1.0.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-25 03:50 UTC by Thiago Sousa Santos
Modified: 2012-10-25 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
imagefreeze: avoid assertion when using accept caps query (1.49 KB, patch)
2012-10-25 03:51 UTC, Thiago Sousa Santos 		committed Details | Review
imagefreeze: the new get_caps already does the filter intersection (1.52 KB, patch)
2012-10-25 03:51 UTC, Thiago Sousa Santos 		committed Details | Review

Description Thiago Sousa Santos 2012-10-25 03:50:25 UTC 
Remove an assertion at setcaps and improve imagefreeze caps negotiation.
Comment 1 Thiago Sousa Santos 2012-10-25 03:51:39 UTC 
Created attachment 227217 [details] [review]
imagefreeze: avoid assertion when using accept caps query

This query must receive a fixed caps, so imagefreeze should
fixate its framerate before sending the query downstream.
Comment 2 Thiago Sousa Santos 2012-10-25 03:51:53 UTC 
Created attachment 227218 [details] [review]
imagefreeze: the new get_caps already does the filter intersection

It should be faster to pass the caps to intersect as the filter caps,
rather than using NULL and intersecting 'manually' later.
Comment 3 Tim-Philipp Müller 2012-10-25 13:35:10 UTC 
git is open again now :)
Comment 4 Thiago Sousa Santos 2012-10-25 13:45:04 UTC 
Comment on attachment 227218 [details] [review]
imagefreeze: the new get_caps already does the filter intersection

Had to do a small update on this patch:

gst_caps_unref(caps);
caps = othercaps;

and pushed
Comment 5 Thiago Sousa Santos 2012-10-25 13:45:59 UTC 
commit 02d91dcd24e54f510419655c2c56c2afc83a1ac5
commit 115581eb2eaca70b892241a13d7d0f381b704caf

Fixed