After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686795 - Replace static PollFD and IOChannel bindings with GI
Replace static PollFD and IOChannel bindings with GI
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
Git master
Other Linux
: Normal enhancement
: GNOME 3.10
Assigned To: Martin Pitt
Python bindings maintainers
Depends on: 686797
Blocks: 685373
 
 
Reported: 2012-10-24 14:04 UTC by Martin Pitt
Modified: 2013-03-25 07:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove static PollFD bindings (10.18 KB, patch)
2012-10-24 14:46 UTC, Martin Pitt
needs-work Details | Review
Remove static PollFD bindings (7.13 KB, patch)
2012-11-03 17:47 UTC, Martin Pitt
needs-work Details | Review
Remove static PollFD bindings (7.05 KB, patch)
2012-11-05 14:05 UTC, Martin Pitt
committed Details | Review

Description Martin Pitt 2012-10-24 14:04:47 UTC
In the same spirit as bug 686443 (and the meta-bug 685373) we want to drop the static _glib bindings of PollFD and IOChannel.

This currently depends on GLib to box GPollFD, I'll file a separate bug for this.
Comment 1 Martin Pitt 2012-10-24 14:46:59 UTC
Created attachment 227154 [details] [review]
Remove static PollFD bindings

This gets rid of the static PollFD bindings, and with it, the remainders of gi/_glib/pygsource.[hc]. However, this depends on the glib patch in https://bugzilla.gnome.org/show_bug.cgi?id=686797, unless we find a workaround to box it in pygobject when running with older glib. But this isn't really that urgent, we can wait until the next glib release.
Comment 2 Martin Pitt 2012-10-24 14:50:20 UTC
Comment on attachment 227154 [details] [review]
Remove static PollFD bindings

Setting to needs-work, as at the minimum, this needs to add a bumping of
glib_required_version in configure.ac.
Comment 3 Martin Pitt 2012-10-25 13:14:50 UTC
I now pushed some annotation fixes into GLib which fix introspection for GIOChannel. Bug 686797 was also resolved in that glib would not box GPollFD, we'd need to do it in pygobject; at least for now.

I have a patch to drop most of the static GIOChannel bindings now, and wrote bug-for-bug compatible overrides instead. I need to clean those up now for the updated GPollFD patch.
Comment 4 Martin Pitt 2012-10-25 13:58:27 UTC
(Most of) static IOChannel bindings removed in trunk:

http://git.gnome.org/browse/pygobject/commit/?id=15e717ce2c2
Comment 5 Martin Pitt 2012-11-03 17:47:38 UTC
Created attachment 227975 [details] [review]
Remove static PollFD bindings

For the record, current version rebased against trunk, mostly for avoiding to lose it accidentally. This still doesn't work, as we either need to box PollFD in glib or get rid of it entirely. Hacking around the gtype not existing in the .gir is too brittle/wrong, I'd rather keep the static bindings until then.
Comment 6 Martin Pitt 2012-11-05 14:05:30 UTC
Created attachment 228111 [details] [review]
Remove static PollFD bindings

Updated to current git head. Now the glib patch landed, so this is unblocked. But we need to wait for a glib release to properly set the minimal glib dependency (glib apparently doesn't use post-release version bumping).
Comment 7 Simon Feltman 2013-02-20 04:31:59 UTC
Martin,

The target milestone for this is set to 3.8, is this ok to put in now or should we wait until 3.10?
Comment 8 Martin Pitt 2013-02-20 07:03:33 UTC
I'm a bit torn here, but my gut feeling is we should move this to 3.10. Otherwise we would have to bump the glib and gobject-introspection dependencies from 2.34 to 2.35.x, and I really like pygobject work with the current stable releases. I don't think there is a particular hurry to land this, or is this blocking any of your other "remove static bindings" work?
Comment 9 Simon Feltman 2013-02-20 07:09:26 UTC
(In reply to comment #8)
> I don't think there is a particular hurry to land this, or is this
> blocking any of your other "remove static bindings" work?

Nope. I have just been marking a few bugs as 3.8 and this was showing up in the search result afterwards :)
Comment 10 Martin Pitt 2013-03-25 07:53:06 UTC
Comment on attachment 228111 [details] [review]
Remove static PollFD bindings

3.8 is branched away now, and in master (which is 3.9.x now) I bumped the glib and gi dependencies, so this can go in now.