After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686792 - gvfs-copy in autogen.sh failed if session bus is not set
gvfs-copy in autogen.sh failed if session bus is not set
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-24 13:46 UTC by JB Lallement
Modified: 2013-03-25 13:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix autogen when there is no dbus session already running (1.26 KB, patch)
2012-10-24 13:46 UTC, JB Lallement 		none Details | Review
Fix download of pnp.ids (1.30 KB, patch)
2012-10-24 15:17 UTC, JB Lallement 		none Details | Review
lib: Remove use of gvfs-copy in autogen.sh (1.36 KB, patch)
2012-10-24 15:48 UTC, Bastien Nocera 		committed Details | Review

Description JB Lallement 2012-10-24 13:46:05 UTC 
Created attachment 227149 [details] [review]
Fix autogen when there is no dbus session already running

Running "jhbuild --check gnome-desktop" failed on a clean environment (Ubuntu 12.10) if there is no session bus already set. 

The root cause is that gvfs-copy fails and an empty pnp.ids is generated. The proposed patch addresses this issue by:
1. Running gvfs-copy through dbus-launch
2. Falling back on wget if it fails
Comment 1 Martin Pitt 2012-10-24 13:56:53 UTC 
Please note that dbus-launch does not automatically clean up the bus again. You need to capture its pid and kill it afterwards.

Please also reformat the changelog for a single short description, empty line, and then the long description.

Thank you!
Comment 2 JB Lallement 2012-10-24 15:17:30 UTC 
Created attachment 227156 [details] [review]
Fix download of pnp.ids

Thanks for your review. Here is a new version of the patch following your comments.
Comment 3 Bastien Nocera 2012-10-24 15:48:27 UTC 
Created attachment 227162 [details] [review]
lib: Remove use of gvfs-copy in autogen.sh
Comment 4 Bastien Nocera 2012-10-24 15:49:30 UTC 
Attachment 227162 [details] pushed as fdb7a78 - lib: Remove use of gvfs-copy in autogen.sh
Comment 5 Bastien Nocera 2013-03-25 13:18:20 UTC 
*** Bug 681649 has been marked as a duplicate of this bug. ***