After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686776 - Shouldn't annotate constructor of GInitiallyUnowned subclasses
Shouldn't annotate constructor of GInitiallyUnowned subclasses
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-24 10:09 UTC by Guillaume Desmottes
Modified: 2012-10-24 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't annotate with (transfer full) constructors of GInitiallyUnowned subclasses (2.96 KB, patch)
2012-10-24 10:11 UTC, Guillaume Desmottes 		committed Details | Review
test script (110 bytes, text/plain)
2012-10-24 11:10 UTC, Guillaume Desmottes 		  Details

Description Guillaume Desmottes 2012-10-24 10:09:22 UTC 
See bug #686697 for the rationale.
Comment 1 Guillaume Desmottes 2012-10-24 10:11:23 UTC 
Created attachment 227128 [details] [review]
Don't annotate with (transfer full) constructors of GInitiallyUnowned subclasses
Comment 2 Emmanuele Bassi (:ebassi) 2012-10-24 10:19:05 UTC 
Review of attachment 227128 [details] [review]:

I distinctly remember adding a bunch of these after introspection users complained, so I'd like to have some confirmation that stripping them is actually working.
Comment 3 Guillaume Desmottes 2012-10-24 11:10:14 UTC 
Created attachment 227133 [details]
test script

This test script crashes without my patch.
Comment 4 Emmanuele Bassi (:ebassi) 2012-10-24 11:14:21 UTC 
Review of attachment 227128 [details] [review]:

okay, let's do this in master - then we can see if something breaks and eventually backport to clutter-1.12.
Comment 5 Guillaume Desmottes 2012-10-24 11:18:34 UTC 
Merged to master. Let me know when/if you want this to the stable branch as well.

Attachment 227128 [details] pushed as 2be88b3 - Don't annotate with (transfer full) constructors of GInitiallyUnowned subclasses
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-10-24 17:17:45 UTC 
The correct annotation would be (transfer floating), if anything. But the scanner will note the GInitiallyUnowned, and default to that.