After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686746 - Port introspection fixes from Vala
Port introspection fixes from Vala
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
unspecified
Other Linux
: Normal minor
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-10-24 01:20 UTC by Evan Nemerson
Modified: 2012-12-02 06:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
introspection: merge fixes from Vala bindings (14.14 KB, patch)
2012-10-24 01:23 UTC, Evan Nemerson 		committed Details | Review
atk: update bindings to account for changes made in atk (13.17 KB, patch)
2012-10-24 01:26 UTC, Evan Nemerson 		committed Details | Review

Description Evan Nemerson 2012-10-24 01:20:55 UTC 
The Vala bindings contain a lot of minor fixes which should really be fixed in atk so other languages can take advantage of them.
Comment 1 Evan Nemerson 2012-10-24 01:23:01 UTC 
Created attachment 227111 [details] [review]
introspection: merge fixes from Vala bindings
Comment 2 Evan Nemerson 2012-10-24 01:26:26 UTC 
Created attachment 227112 [details] [review]
atk: update bindings to account for changes made in atk

Patch to account for the changes in Vala.
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-10-24 10:54:33 UTC 
Review of attachment 227111 [details] [review]:

Look good to me
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-10-24 10:56:12 UTC 
(In reply to comment #2)
> Created an attachment (id=227112) [details] [review]
> atk: update bindings to account for changes made in atk
> 
> Patch to account for the changes in Vala.

This seems in fact a vala patch (and as I'm not a vala maintainer, not the person to review it), probably it would be better to have two bugs, an atk bug and a vala bug, and setting the dependency between them if required.