After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686719 - Missing linker flags in Camel tests
Missing linker flags in Camel tests
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
3.6.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 689158 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-23 18:57 UTC by JB Lallement
Modified: 2012-11-27 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add explicit link to required objects (2.20 KB, patch)
2012-10-23 18:57 UTC, JB Lallement 		committed Details | Review

Description JB Lallement 2012-10-23 18:57:17 UTC 
Created attachment 227088 [details] [review]
Patch to add explicit link to required objects

Running "jhbuild build --check evolution-data-server" on Ubuntu 12.10 failed because tests failed to build with the following error:

"""Making check in message
make[4]: Entering directory `/home/ubuntu/gnome/checkout/evolution-data-server/camel/tests/message'
make  test1 test2 test3 test4
make[5]: Entering directory `/home/ubuntu/gnome/checkout/evolution-data-server/camel/tests/message'
  CC     test1-test1.o
  CCLD   test1
/usr/bin/ld: ../../../camel/tests/lib/libcameltest.a(libcameltest_a-messages.o): undefined reference to symbol 'g_seekable_seek'
/usr/bin/ld: note: 'g_seekable_seek' is defined in DSO /home/ubuntu/gnome/packages/lib64/libgio-2.0.so.0 so try adding it to the linker command line
/home/ubuntu/gnome/packages/lib64/libgio-2.0.so.0: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
"""

The proposed patch attached addresses this issue
Comment 1 Matthew Barnes 2012-10-25 23:27:58 UTC 
Hmm, I can't seem to reproduce the linker failure on my Debian machine, even when using LDFLAGS="-Wl,--as-needed".  Patch looks correct but I'd first like to verify it for myself.  Any idea what magic option I might be missing?
Comment 2 Martin Pitt 2012-10-26 04:23:02 UTC 
I think this is --no-add-needed, which disables the resolution of symbols through transitive library dependencies (http://wiki.debian.org/ToolChain/DSOLinking). Perhaps try to install binutils-gold? I think it does that by default.
Comment 3 Matthew Barnes 2012-10-26 15:32:10 UTC 
Thanks Martin, binutils-gold did the trick.  I can now reproduce the linker failure and verify the patch on my Debian machine.

Note that "make check" still will not pass because the E-D-S test suite is rather broken at the moment.  I'm hoping to address that by 3.8.0.  But the patch is one less obstacle, at least.

Committed for E-D-S 3.7.2 and 3.6.2:

http://git.gnome.org/browse/evolution-data-server/commit/?id=52f87cba60b4d65a3d91718c25afc66d34db7db5

http://git.gnome.org/browse/evolution-data-server/commit/?h=gnome-3-6&id=5ce9ff162effaa170af34ff3f4b8d6d5b79692d1
Comment 4 Murray Cumming 2012-11-27 13:42:27 UTC 
*** Bug 689158 has been marked as a duplicate of this bug. ***