After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686695 - support nickname in add_persona_from_details
support nickname in add_persona_from_details
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other Linux
: Normal enhancement
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-23 10:09 UTC by Patrick Ohly
Modified: 2013-01-09 21:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support nickname in add_persona_from_details() in the EDS backend (5.52 KB, patch)
2012-12-30 18:54 UTC, Philip Withnall 		committed Details | Review

Description Patrick Ohly 2012-10-23 10:09:52 UTC 
Full name can be set, but not the nickname although EDS supports it and reading of it works.

Please add support for creating a Persona with nickname and updating it. I have not tested whether updating the nickname works (need to add some code to SyncEvolution once there is a PERSONA_DETAIL_NICKNAME).
Comment 1 Philip Withnall 2012-12-30 18:54:42 UTC 
Created attachment 232409 [details] [review]
Support nickname in add_persona_from_details() in the EDS backend

https://www.gitorious.org/folks/folks/commits/686695-eds-add-persona-by-nickname
Comment 2 Travis Reitter 2013-01-08 06:58:30 UTC 
Review of attachment 232409 [details] [review]:

Looks generally good. My only hesitation is our notion of nickname as contact-set (see the comment for NameDetails.nickname).

But I guess we need this functionality for compatibility's sake (since vCard never tries to claim any fields are explicitly contact-set). Assuming you agree with that, please merge.
Comment 3 Philip Withnall 2013-01-09 21:53:19 UTC 
commit a39f2b2e9d20342db9650c432e0b708a50c42de7
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sun Dec 30 18:53:08 2012 +0000

    Bug 686695 — support nickname in add_persona_from_details
    
    Support nicknames in add_persona_from_details() in the EDS backend. This
    adds a test case (which passes).
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=686695

 NEWS                                     |  1 +
 backends/eds/lib/edsf-persona-store.vala | 12 ++++++++++++
 tests/eds/add-persona.vala               | 15 +++++++++++++++
 3 files changed, 28 insertions(+)