After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686637 - Check for NULL GMountOperation while unmounting
Check for NULL GMountOperation while unmounting
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-22 13:04 UTC by Debarshi Ray
Modified: 2012-10-24 08:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdaemonmount: Check for a NULL GMountOperation when unmounting (969 bytes, patch)
2012-10-22 13:07 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2012-10-22 13:04:18 UTC 
g_mount_unmount_with_operation is supposed to accept NULL as its mount_operation parameter. However, g_daemon_mount_unmount_with_operation does not check for NULL before trying to get a reference on the mount_operation.
Comment 1 Debarshi Ray 2012-10-22 13:07:40 UTC 
Created attachment 226990 [details] [review]
gdaemonmount: Check for a NULL GMountOperation when unmounting
Comment 2 Debarshi Ray 2012-10-22 13:08:38 UTC 
Fortunately g_mount_operation_dbus_wrap handles a NULL mount_operation elegantly, so things don't crash later on.
Comment 3 Alexander Larsson 2012-10-24 07:22:01 UTC 
Review of attachment 226990 [details] [review]:

ack, please commit on master and gnome-3-6.
Comment 4 Debarshi Ray 2012-10-24 08:55:28 UTC 
Pushed to both master and gnome-3-6.