After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686628 - AVTransport treats REL_TIME and ABS_TIME seeks the same
AVTransport treats REL_TIME and ABS_TIME seeks the same
Product: rygel
Classification: Applications
Component: librygel-renderer
git master
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
Depends on:
Reported: 2012-10-22 11:45 UTC by Jens Georg
Modified: 2018-05-22 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Fix seeking behavior when using REL_TIME (3.18 KB, patch)
2013-09-10 22:40 UTC, milan.plzik
committed Details | Review

Description Jens Georg 2012-10-22 11:45:23 UTC
I suppose this was done to get maximum compatibility but UPnP-wise that's just wrong, see AVTransport:2 spec, Section 2.4.13
Comment 1 milan.plzik 2013-09-10 22:40:48 UTC
Created attachment 254630 [details] [review]
Fix seeking behavior when using REL_TIME

Attached patch fixes behavior of 'Seek', so that relative seek is always done relative to current time. No value checking is done, thus calling player's seek with negative time is possible.
Comment 2 Jens Georg 2013-09-30 09:53:36 UTC
Committed with minor style fix
Comment 3 emmanuel.cabestan 2013-12-20 17:23:25 UTC
I think the fix isn't correct. The relative is not from the current time but from the current track.

see AVTransport:2 spec, Section 2.4.13 :
"For example, if the
RelativeTimePosition state variable contains the value “00:05:30” before the Seek() action, then
Seek(InstanceID, “REL_TIME”, “00:00:10”) will move the current position to 10 seconds from the
beginning of the track and the RelativeTimePosition state variable will contain the value “00:00:10” after
the Seek() action is completed."

With this fix we have 00:05:40 instead of 00:00:10.

I think the previous code was less wrong.
Comment 4 Jens Georg 2013-12-21 10:12:23 UTC
Comment 5 Jens Georg 2013-12-21 10:18:05 UTC
Still, reverting this makes UPnP or DLNA CTT fail IIRC, so this might need some investigation.
Comment 6 GNOME Infrastructure Team 2018-05-22 12:36:31 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: