After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686626 - Remove ConsoleKit path
Remove ConsoleKit path
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-22 11:40 UTC by Bastien Nocera
Modified: 2014-04-25 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
loginManager: Kill ConsoleKit support (4.57 KB, patch)
2014-04-24 17:14 UTC, Florian Müllner
committed Details | Review

Description Bastien Nocera 2012-10-22 11:40:37 UTC
Bug 686482 adds support for systemd in addition to ConsoleKit/upower for suspending. We should just remove the suspend support through ConsoleKit/upower.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-10-22 14:15:53 UTC
Why?
Comment 2 Bastien Nocera 2012-10-22 14:17:33 UTC
Because gnome-settings-daemon doesn't support it anymore. See the discussion on d-d-l.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-10-22 14:19:52 UTC
(In reply to comment #2)
> Because gnome-settings-daemon doesn't support it anymore. See the discussion on
> d-d-l.

That discussion is far from over and decided. I won't be willing to remove the code path until we're all in agreement.
Comment 4 Matthias Clasen 2012-10-22 14:30:43 UTC
We'll certainly discuss this at the release team meeting next weekend.
Please hold off on more code removal until then
Comment 5 Florian Müllner 2014-04-24 17:14:58 UTC
Created attachment 275071 [details] [review]
loginManager: Kill ConsoleKit support

The code path is completely unmaintained and untested (and probably
unused as well, considering that nobody has complained about accessing
the session object's Active property which does not exist in the
ConsoleKit case).
Most of our ConsoleKit code is already a dummy anyway, just do the
same for the remaining functionality.
Comment 6 Rui Matos 2014-04-25 12:23:35 UTC
Review of attachment 275071 [details] [review]:

looks good

::: js/misc/loginManager.js
@@ -218,3 @@
-    // Having this function is a bit of a hack since the Systemd and ConsoleKit
-    // session objects have different interfaces - but in both cases there are
-    // Lock/Unlock signals, and that's all we count upon at the moment.

I guess you can remove the copy of this comment further up in the systemd class too
Comment 7 Florian Müllner 2014-04-25 13:58:04 UTC
Attachment 275071 [details] pushed as a244c1e - loginManager: Kill ConsoleKit support