GNOME Bugzilla – Bug 686588
Change location of Python files
Last modified: 2015-10-20 13:12:34 UTC
Currently, Python files are installed in $PREFIX/lib/pitivi/python/pitivi/ can be use an another "schema" for example $PREFIX/lib/pitivi-X.Y/pitivi Where X is major version and Y minor version.
With all respect, what would be the need/use for that? Pitivi developers can't afford to support more than one release at any given time anyway... why complicate setup scripts and the job of downstream packagers?
(In reply to comment #1) > With all respect, what would be the need/use for that? > > Pitivi developers can't afford to support more than one release at any given > time anyway... why complicate setup scripts and the job of downstream > packagers? I find $PREFIX/lib/pitivi/python/pitivi/ is redundant. In your lib/ directory some libraries use this "schema", so why not PiTiVi :) About packagers, I did it for FreeBSD users http://www.freebsd.org/cgi/query-pr.cgi?pr=172366
Ah I see, in Fedora for instance the code is installed as /usr/share/pitivi/python/pitivi which would kind of make more sense if it was /usr/share/pitivi/python or /usr/lib/pitivi (though there are other files inside /usr/share/pitivi) Thing is, I know nothing about packaging and I'm very nervous about touching such installation scripts that I didn't write... however if you provide a patch to improve this on all platforms, I could probably ask around for feedback from Debian and Fedora packagers.
Created attachment 229302 [details] [review] Change path of libdir
(In reply to comment #4) > Created an attachment (id=229302) [details] [review] > Change path of libdir My comment has been lost :( So, this patch change path in libdir, now python files placed into $PREFIX/lib/pitivi-X.Y/pitivi. Where X is major version and Y minor I tested this patch under 0.15.2 release, every macros (PACKAGE_VERSION_MAJOR and PACKAGE_VERSION_MINOR) are replaced by their values, after autogen.sh script has been launched. Note: diff was made after commit affb11743102c96cc7adedf808a2608941e65792 (in master branch).
While at that you should also consider putting .py files into /usr/share/pitivi (i.e. $pkgdatadir) and .so files in /usr/lib/pitivi (i.e. $pkglibdir). Putting the version number into the file name just seems ugly and confusing, pitivi will never be parallel installable in different versions, right?
The split between both dirs because datadir is for platform-independent files, and libdir for platform-dependent files.
This bug has been migrated to https://phabricator.freedesktop.org/T2994. Please use the Phabricator interface to report further bugs by creating a task and associating it with Project: Pitivi. See http://wiki.pitivi.org/wiki/Bug_reporting for details.