After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686561 - Add version definitions to libgoa
Add version definitions to libgoa
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.6.x
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks: 686528 686529
 
 
Reported: 2012-10-21 03:20 UTC by Matthew Barnes
Modified: 2012-10-21 17:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
goa: Add version definitions (12.87 KB, patch)
2012-10-21 16:37 UTC, Debarshi Ray 		none Details | Review
goa: Add version definitions (14.96 KB, patch)
2012-10-21 17:18 UTC, Debarshi Ray 		committed Details | Review

Description Matthew Barnes 2012-10-21 03:20:23 UTC 
Given the accumulation of new GOA providers over time (Exchange, Kerberos, and now OwnCloud), it's important that libgoa provide version macros so applications can optionally utilize new provider APIs without requiring a bleeding-edge version of GOA.

Basically I'd like to be able to do this from Evolution-Data-Server:

#if GOA_CHECK_VERSION(3,7,1)
    ... put OwnCloud integration here ...
#endif

You can copy from GLib, GTK+ or even E-D-S:

http://developer.gnome.org/glib/stable/glib-Version-Information.html

http://developer.gnome.org/gtk3/stable/gtk3-Feature-Test-Macros.html

http://developer.gnome.org/libedataserver/stable/libedataserver-Version-Information.html
Comment 1 Debarshi Ray 2012-10-21 16:37:49 UTC 
Created attachment 226932 [details] [review]
goa: Add version definitions
Comment 2 Debarshi Ray 2012-10-21 17:18:52 UTC 
Created attachment 226935 [details] [review]
goa: Add version definitions
Comment 3 Debarshi Ray 2012-10-21 17:20:06 UTC 
Comment on attachment 226935 [details] [review]
goa: Add version definitions

Testing with a toy program gave satisfactory results.
Comment 4 Debarshi Ray 2012-10-21 17:23:07 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 5 Matthew Barnes 2012-10-21 17:40:49 UTC 
Thanks, that will be very helpful!