After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686530 - Dash resize is delayed until you enter the overview
Dash resize is delayed until you enter the overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-20 15:43 UTC by Alex Hultman
Modified: 2012-11-12 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dash: Disable animations during overview transitions (2.10 KB, patch)
2012-10-30 19:57 UTC, Florian Müllner
committed Details | Review

Description Alex Hultman 2012-10-20 15:43:53 UTC
Closing an app that is not a favorite shrinks the dash. In previous versions this happens right away but in 3.6 the shrink animation only starts when you enter overview.

This looks very strange because sometimes you closed the app a long time ago and when you go to overview the dash suddenly shrinks. Same goes for growth.
Comment 1 Allan Day 2012-10-30 18:42:13 UTC
Wow, well spotted! Took me a while to notice that one, but there is an extra transition displayed that isn't necessary.
Comment 2 Florian Müllner 2012-10-30 19:25:53 UTC
(In reply to comment #0)
> Closing an app that is not a favorite shrinks the dash. In previous versions
> this happens right away but in 3.6 the shrink animation only starts when you
> enter overview.

Not that it matters much, but this was always the case in previous versions. You may not have noticed it before, because the animations does not only start when entering the overview - the dash is updated while the overview is hidden, but work is done lazily (if you wait ~20 seconds after closing/opening an app, you should not see any resizing going on when entering the overview).

Anyway, patch coming ...
Comment 3 Florian Müllner 2012-10-30 19:57:55 UTC
Created attachment 227679 [details] [review]
dash: Disable animations during overview transitions

When updating the dash, we already avoid all animations while the
overview is hidden. However, as we are using Main.queueDeferredWork(),
updates may be deferred up to ~20 seconds while the overview is hidden.
If the overview is entered before a queued update has taken place, it
will be run immediately on map - as the overview is visible by then,
this means animating any outstanding changes.
Work around this by skipping animations during overview transitions as
well.
Comment 4 Alex Hultman 2012-10-31 11:30:36 UTC
I think I haven't noticed it in previous versions because the dash wasn't centered vertically. It's a lot more noticeable when the whole dash suddenly shrinks and moves, but you are correct - I noticed it on 3.4 now :)
Comment 5 drago01 2012-11-04 10:45:57 UTC
Review of attachment 227679 [details] [review]:

Makes sense, the comments in the code need to be updated though (see below).
Fine to push with them fixed.

::: js/ui/dash.js
@@ +746,3 @@
             let item = removedActors[i]._delegate;
 
             // Don't animate item removal when the overview is hidden

The comments do not match the code anymore. Update them.
Comment 6 Florian Müllner 2012-11-12 16:00:11 UTC
Attachment 227679 [details] pushed as f602993 - dash: Disable animations during overview transitions