After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686510 - tomboy has an automagic dependency on multiple gmime versions
tomboy has an automagic dependency on multiple gmime versions
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
1.12.x
Other Linux
: Normal normal
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-20 07:16 UTC by Pacho Ramos
Modified: 2012-10-24 18:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tomboy-1.12.1-force-gmime26.patch (730 bytes, patch)
2012-10-20 07:16 UTC, Pacho Ramos 		reviewed Details | Review
0001-Force-gmime-2.6-usage-to-prevent-automagic-dependenc.patch (1.08 KB, patch)
2012-10-23 17:33 UTC, Pacho Ramos 		none Details | Review
0001-Force-gmime-2.6-usage-to-prevent-automagic-dependenc.patch (1.09 KB, patch)
2012-10-23 17:34 UTC, Pacho Ramos 		committed Details | Review

Description Pacho Ramos 2012-10-20 07:16:05 UTC 
Created attachment 226870 [details] [review]
tomboy-1.12.1-force-gmime26.patch

Explained at:
http://www.gentoo.org/proj/en/qa/automagic.xml

tomboy is checking for gmime-2.4, later gmime-2.6 and, finally, gmime-2.2. If both, gmime-2.4 and 2.6 are installed at compile time, tomboy will use gmime-2.4 and, then, if later gmime-2.4 is removed due no package really needing it (as, currently, nearly all packages are moved to support gmime-2.6 also), it will break.

Ideally, tomboy would have a "--with-gmime=[2.2,2.4,2,6]" configure option... but taken care gmime-2.2 is dead and the same will occur for 2.4, I think it doesn't deserve the effort and we could for 2.6 usage (like attached patch does).
Comment 1 Jared Jennings 2012-10-22 03:41:34 UTC 
Does this mean that it is very important that whomever builds a release of tomboy has the latest gmime installed? Err at least the 2.6 version.
Comment 2 Jared Jennings 2012-10-22 03:42:10 UTC 
Review of attachment 226870 [details] [review]:

This patch looks smart, but am waiting back on my question about having 2.6 installed during release time.
Comment 3 Pacho Ramos 2012-10-22 06:15:16 UTC 
The other way would be to do something similar to balsa, that allows --with-gmime=x.x configure option to set the gmime version to compile with. The problem is that:
- gmime-2.2 is not maintained by upstream for a long time and he asked us to move to newer versions.
- gmime-2.4 is also being deprecated and, if you see major distributions like fedora, opensuse, debian... they are only providing gmime-2.6 because no package is left with gmime < 2.6 compat only
Comment 4 Jared Jennings 2012-10-23 04:02:40 UTC 
Pacho, can you resubmit the patch using "git format-patch HEAD^" unless you do not want credit for the patch. The current patch is just a raw diff.
Comment 5 Pacho Ramos 2012-10-23 17:33:09 UTC 
Created attachment 227084 [details] [review]
0001-Force-gmime-2.6-usage-to-prevent-automagic-dependenc.patch

This should be ok I think
Comment 6 Pacho Ramos 2012-10-23 17:34:03 UTC 
Created attachment 227085 [details] [review]
0001-Force-gmime-2.6-usage-to-prevent-automagic-dependenc.patch

This adds a reference to this bug report
Comment 7 Jared Jennings 2012-10-24 18:23:30 UTC 
Review of attachment 227085 [details] [review]:

Yes much better!
Commit 3cbf464f94e1e5048545bf462d9dc36d61332e8e