After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686506 - Make zeitgeist dependency optional again
Make zeitgeist dependency optional again
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-20 03:40 UTC by Matthias Clasen
Modified: 2013-04-18 09:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.44 KB, patch)
2012-10-20 03:40 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2012-10-20 03:40:28 UTC 
Created attachment 226868 [details] [review]
patch

We don't want to ship zeitgeist in RHEL, so having it as a hard dependency of folks is inconvenient. It does not really add a ton of value to have it as a hard dependency, either.

Here is a patch that makes it optional again.
Comment 1 Philip Withnall 2012-10-21 09:58:32 UTC 
Review of attachment 226868 [details] [review]:

Looks good to me. Can you fix the one comment below and then commit to master *with a suitable NEWS entry* please? Thanks.

::: folks-0.8.0/configure.ac.zeitgeist
@@ +194,3 @@
         PKG_CHECK_MODULES([TP_GLIB], [telepathy-glib >= $TP_GLIB_REQUIRED])
+        PKG_CHECK_MODULES([ZEITGEIST], [zeitgeist-1.0 >= $ZEITGEIST_REQUIRED],
+	                   have_zeitgeist="yes",have_zeitgeist="no")])

Could you please add a line to the ‘Configure summary’ mentioning whether Zeitgeist support is enabled?
Comment 2 Guillaume Desmottes 2012-10-22 08:23:44 UTC 
Bug #677428 is no longer an issue?
Comment 3 Matthias Clasen 2012-10-23 16:24:22 UTC 
Pushed to master, with a summary line.