After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686505 - xsettings: Optimize xsettings changes
xsettings: Optimize xsettings changes
Product: gnome-settings-daemon
Classification: Core
Component: xsettings
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
Depends on:
Reported: 2012-10-20 03:35 UTC by Matthias Clasen
Modified: 2012-10-21 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

xsettings: Optimize xsettings changes (6.94 KB, patch)
2012-10-20 03:35 UTC, Matthias Clasen
accepted-commit_now Details | Review

Description Matthias Clasen 2012-10-20 03:35:26 UTC
I've noticed that we are updating XSettings several times during
login, which wakes up all running GTK+ apps, and possibly makes then
do a lot of work due to theme or font changes.

This patch addresses this in two ways:
1) Assume that gnome-shell will be running, and initialize the
   appmenu setting accordingly. This avoids a change when the shell
   comes on the bus later (g-s-d starts before the shell)
2) Batch updates in an idle

With these changes, I see XSettings getting set exactly once during
login, which is as it should be.
Comment 1 Matthias Clasen 2012-10-20 03:35:29 UTC
Created attachment 226867 [details] [review]
xsettings: Optimize xsettings changes
Comment 2 Bastien Nocera 2012-10-20 10:07:16 UTC
Review of attachment 226867 [details] [review]:

Great stuff.