After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686492 - Use libgnome-volume-control from a submodule
Use libgnome-volume-control from a submodule
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-19 18:46 UTC by Giovanni Campagna
Modified: 2012-11-13 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use libgnome-volume-control from a submodule (215.56 KB, patch)
2012-10-19 18:46 UTC, Giovanni Campagna
needs-work Details | Review
Use libgnome-volume-control from a submodule (215.53 KB, patch)
2012-10-22 20:18 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2012-10-19 18:46:39 UTC
As discussed in the mailing list
Comment 1 Giovanni Campagna 2012-10-19 18:46:42 UTC
Created attachment 226851 [details] [review]
Use libgnome-volume-control from a submodule

To be shared with gnome-control-center and gnome-shell
Comment 2 Bastien Nocera 2012-10-22 12:13:21 UTC
Review of attachment 226851 [details] [review]:

::: configure.ac
@@ +206,2 @@
 PKG_CHECK_MODULES(MEDIA_KEYS, [gio-unix-2.0 libpulse >= $PA_REQUIRED_VERSION $GUDEV_PKG libpulse-mainloop-glib >= $PA_REQUIRED_VERSION libcanberra])
+PKG_CHECK_MODULES(GVC, [gobject-2.0 gtk+-3.0 libpulse >= $PA_REQUIRED_VERSION libpulse-mainloop-glib >= $PA_REQUIRED_VERSION libcanberra-gtk3])

We really shouldn't need to link to GTK+ for this. There's probably a huge bunch of code that's getting compiled that shouldn't be.
Comment 3 Giovanni Campagna 2012-10-22 20:18:56 UTC
Created attachment 227020 [details] [review]
Use libgnome-volume-control from a submodule

To be shared with gnome-control-center and gnome-shell
Comment 4 Bastien Nocera 2012-11-13 15:52:20 UTC
Attachment 227020 [details] pushed as ea17ab0 - Use libgnome-volume-control from a submodule