After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686487 - workspacesView: Fix some errors in code paths for non-default settings
workspacesView: Fix some errors in code paths for non-default settings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-19 18:16 UTC by Florian Müllner
Modified: 2012-10-23 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspacesView: Fix typo (975 bytes, patch)
2012-10-19 18:17 UTC, Florian Müllner 		committed Details | Review
workspacesView: Fix updating when number of workspaces changes (1.29 KB, patch)
2012-10-19 18:17 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-10-19 18:16:59 UTC 
See patches.
Comment 1 Florian Müllner 2012-10-19 18:17:02 UTC 
Created attachment 226847 [details] [review]
workspacesView: Fix typo

We want to check for a setting, not the existence of a function.
Comment 2 Florian Müllner 2012-10-19 18:17:06 UTC 
Created attachment 226848 [details] [review]
workspacesView: Fix updating when number of workspaces changes

Ouch. This went unnoticed for a long time as by default (using
dynamic workspaces) only one workspace is added at a time, which
happens to work fine.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-10-19 18:27:22 UTC 
Review of attachment 226848 [details] [review]:

I noticed this before, but I didn't question it. Thought it was strange, but intended somehow.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-19 18:27:49 UTC 
Review of attachment 226847 [details] [review]:

Sure.
Comment 5 Florian Müllner 2012-10-23 16:29:18 UTC 
Attachment 226847 [details] pushed as 96a80f7 - workspacesView: Fix typo
Attachment 226848 [details] pushed as a2b1946 - workspacesView: Fix updating when number of workspaces changes