GNOME Bugzilla – Bug 686472
Incorrect badge placement
Last modified: 2012-12-03 10:26:15 UTC
When there are missed messages from a message tray item, we display a badge with a count of the number of missed message. Right now, that badge is placed too centrally, so that it obscures a large part of the tray item. In the case of chat contacts, this often results in the badge overlapping a large portion of their face. It would be better if the badges were moved so that they are overhanging the edge of tray items and do not overlap as much.
Created attachment 227185 [details] 17x13 overlap 2.4em size
Created attachment 227187 [details] The same configuration but clipped to see it better
After few tries this is the better. The badge is moved to the right more than to down, because the visual effect seeing it from distance if the badge is too down is ugly. Instead, the visual effect to the right is not ugly. Also the badge is a little smaller than before, to let more space to the avatar, but without overlapping the text counter with two digits. If you like it tell me and I'll push the patch.
(In reply to comment #2) > Created an attachment (id=227187) [details] > The same configuration but clipped to see it better Thanks for looking at this, Carlos. The screenshot looks good to me: can you post your patch here for review?
Created attachment 227248 [details] [review] gnome-shell.css: Adjust missed message counter size and position from message tray items to not obscure them.
I haven't got commit permission, so if the patch is good, commit it. Thanks
Review of attachment 227248 [details] [review]: There is a problem with this patch: the same counters are used in the lock screen, and there the counter is clipped. You need either to fix the sizing of SourceActors to include the counters (which would probably mess the message tray), or have a different style in the lock screen.
Giovanni, Probably we want to approximate the style of both counters, so I will try with different configurations to try to use the same style for both, once I finally know how to run lock-screen in jhbuild.
(In reply to comment #7) > Review of attachment 227248 [details] [review]: > > There is a problem with this patch: the same counters are used in the lock > screen, and there the counter is clipped. > You need either to fix the sizing of SourceActors to include the counters > (which would probably mess the message tray), or have a different style in the > lock screen. Where / why do we clip the actor?
I have no idea, but I can provide you with a screenshot if you want.
Created attachment 227298 [details] Current patch in lock screen
Best guess is the scroll view, not allowing things to paint outside of its allocation. I'm not sure what the best solution is for that -- maybe modify the scroll to not push a clip at all if we don't need it?
(In reply to comment #12) > Best guess is the scroll view, not allowing things to paint outside of its > allocation. I'm not sure what the best solution is for that -- maybe modify the > scroll to not push a clip at all if we don't need it? I'm not exactly sure what that means, so at the risk of sounding stupid - wouldn't it make sense to adjust the layout of the list so that each "cell" in the list can accommodate a badge if necessary? Looking at the mockups, there is quite a bit of padding between each item: https://raw.github.com/gnome-design-team/gnome-mockups/master/system-lock-login-boot/lock.png
(In reply to comment #13) > (In reply to comment #12) > I'm not exactly sure what that means, so at the risk of sounding stupid - > wouldn't it make sense to adjust the layout of the list so that each "cell" in > the list can accommodate a badge if necessary? Yeah, that's an easier solution. By the way, do we want to move the badge in the message tray as well?
(In reply to comment #14) > By the way, do we want to move the badge in > the message tray as well? I'm not sure what you mean there.
The mockup has the badge at the top right. Do we want that for the lock screen only, or for the tray too?
(In reply to comment #16) > The mockup has the badge at the top right. Do we want that for the lock screen > only, or for the tray too? Oh I see. No, I'd keep them both in the bottom right like we currently have.
patch working: http://postimage.org/image/jrpy8mk5l/ changed position of the badge to 13px at the right, because in the previous patch the badge overlaps a little the notification "square glow" at the right in the message tray.
Created attachment 229013 [details] [review] MessageTray, screenShield: Adjust missed message counter size and position from message tray and screenShield items to not obscure them. Also, add some padding in screenShield notifications to make space to the new position of the badge.
Created attachment 229462 [details] [review] tweaked patch Looks great to me! One small tweak - I'd reduce the padding between the icon and the text for notifications in the lock screen (I've updated the patch).
Oh, ok, I augmented the padding because it was more vision-relaxed to me, but ok =)
I saw that this is marked NEEDS REVIEW in the wiki page. The patch looks fine to me, and it seems to work fine too. You can consider this an accepted-commit_now, as long as you rewrite the commit message using the proper format of summary (~ 85 chars) and longer word wrapped description. Thank you!
Created attachment 230105 [details] [review] MessageTray, screenShield: Adjust missed message counter size and position and add some padding in screenShield notifications to not obscure the items below the missed message counter.
Is the commit message good now? Maybe my English is not good. Tell me something if it is not. Thanks!
The content of the commit message is fine, but it should be formatted as summary ''' One line of summary Longer multi-line description. ''' I would go with: MessageTray, ScreenShield: adjust missed message counter Fix counter size and position and add some padding in ScreenShield notifications to not obscure the items below the missed message counter.
Created attachment 230121 [details] [review] MessageTray, ScreenShield: adjust missed message counter Fix counter size and position and add some padding in ScreenShield notifications to not obscure the items below the missed message counter.
Thanks Giovanni, I didn't know I have to do it in this manner.
Review of attachment 230121 [details] [review]: Seems to have a whitespace issue. Good to commit with that fixed. ::: data/theme/gnome-shell.css @@ +2313,3 @@ +.screen-shield-notification-count-text { + padding: 0px 18px; No tabs.
Created attachment 230129 [details] [review] MessageTray, ScreenShield: adjust missed message counter Fix counter size and position and add some padding in ScreenShield notifications to not obscure the items below the missed message counter.
Sorry for that Jasper. Good catch.
Pushed as Carlos doesn't have commit rights yet. Attachment 230129 [details] pushed as 00c78d3 - MessageTray, ScreenShield: adjust missed message counter
Awesome. Very happy to see this fixed.