After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686406 - MetaPluginManager: don't send events to Clutter twice
MetaPluginManager: don't send events to Clutter twice
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-18 19:01 UTC by Owen Taylor
Modified: 2012-11-03 23:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MetaPluginManager: don't send events to Clutter twice (1.28 KB, patch)
2012-10-18 19:01 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2012-10-18 19:01:17 UTC 
When support for multiple plugins was removed, the logic that was
supposed to send events to Clutter directly *only if there is no filter
function from a plugin* was broken, so events were being sent to
Clutter twice if Clutter didn't consume them the first time.
Comment 1 Owen Taylor 2012-10-18 19:01:18 UTC 
Created attachment 226768 [details] [review]
MetaPluginManager: don't send events to Clutter twice
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-18 19:28:23 UTC 
Review of attachment 226768 [details] [review]:

I thought the point was that if you returned FALSE from the filter, you were marked as not sending the event to Clutter? I guess I understood it wrong, then.
Comment 3 Owen Taylor 2012-10-19 01:23:56 UTC 
The comment above explains:

  /* We need to make sure that clutter gets certain events, like                                                                              
   * ConfigureNotify on the stage window. If there is a plugin that                                                                           
   * provides an xevent_filter function, then it's the responsibility                                                                         
   * of that plugin to pass events to Clutter. Otherwise, we send the                                                                         
   * event directly to Clutter ourselves.                                                                                                     
   */
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-19 01:26:42 UTC 
I somehow misread that... a few times.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-11-03 23:37:08 UTC 
Attachment 226768 [details] pushed as f258556 - MetaPluginManager: don't send events to Clutter twice