GNOME Bugzilla – Bug 686397
user-accounts: Don't have domains twice in the drop down
Last modified: 2012-10-19 08:49:23 UTC
If we discover domains again, don't add them twice to the drop down and confuse the user. This is especially important if we receive two realms from realmd for the same domain for use with different clients (ie: sssd/winbind). We only want to offer the first choice, which is the one realmd indicated as preferred. We may already have a domain listed in the drop down, and then it gets discovered again (via typing).
Created attachment 226753 [details] [review] user-accounts: Don't have domains twice in the drop down If we discover domains again, don't add them twice to the drop down and confuse the user. This is especially important if we receive two realms from realmd for the same domain for use with different clients (ie: sssd/winbind). We only want to offer the first choice
Hello vim user.
Review of attachment 226753 [details] [review]: Looks good apart from the while loop. ::: panels/user-accounts/um-account-dialog.c @@ +347,3 @@ + */ + + model = GTK_TREE_MODEL (self->enterprise_realms); I prefer: ret = gtk_tree_model_get_iter_first (model, &iter); while (ret) { [do things] ret = gtk_tree_model_iter_next (model, &iter); }
Reworked the while loop as requested. Fixed g_debug() statements so they match what's going on. Attachment 226753 [details] pushed as 48ae461 - user-accounts: Don't have domains twice in the drop down