After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686383 - user-accounts: wrong sensitivity of the autologin combo
user-accounts: wrong sensitivity of the autologin combo
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 695922 695923 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-18 14:31 UTC by Ondrej Holy
Modified: 2013-03-21 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-accounts: fix wrong sensitivity of the autologin combo (1005 bytes, patch)
2012-10-18 14:31 UTC, Ondrej Holy 		reviewed Details | Review
user-accounts: fix wrong sensitivity of the autologin combo (1.11 KB, patch)
2012-10-19 08:19 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2012-10-18 14:31:08 UTC 
Created attachment 226742 [details] [review]
user-accounts: fix wrong sensitivity of the autologin combo

The autologin combo in user account panel is wrongly changing its sensitivity (if the panel is locked).

Steps to reproduce:

1) Open user accounts (the autologin combo is insensitive).
2) Change name, language or password.
3) The autologin combo is sensitive now, but it shouldn't (the panel is still locked).

I have attached patch to fix it.
Comment 1 Matthias Clasen 2012-10-18 23:08:47 UTC 
Review of attachment 226742 [details] [review]:

::: panels/user-accounts/um-user-panel.c
@@ +594,2 @@
         g_signal_handlers_unblock_by_func (widget, autologin_changed, d);
 

I don't think taking this out entirely is correct. You are right that we don't want to make the switch sensitive just because the account is not disabled, but we most do want to make the switch insensitive if the account _is_ disabled. So, I suggest this should instead be:

if (um_user_get_locked (user))
  gtk_widget_set_sensitive (widget, FALSE);
Comment 2 Ondrej Holy 2012-10-19 08:19:39 UTC 
Created attachment 226799 [details] [review]
user-accounts: fix wrong sensitivity of the autologin combo

You are right, I'm sorry, so there is fixed patched...
Comment 3 Bastien Nocera 2012-10-19 08:22:20 UTC 
Review of attachment 226799 [details] [review]:

Looks good.
Comment 4 Bastien Nocera 2012-10-22 12:27:00 UTC 
Attachment 226799 [details] pushed as e7722d9 - user-accounts: fix wrong sensitivity of the autologin combo
Comment 5 Ondrej Holy 2013-03-21 11:41:34 UTC 
*** Bug 695922 has been marked as a duplicate of this bug. ***
Comment 6 Ondrej Holy 2013-03-21 11:42:19 UTC 
*** Bug 695923 has been marked as a duplicate of this bug. ***