After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686339 - power: Add a watchdog to keep X's builtin screen saver disabled
power: Add a watchdog to keep X's builtin screen saver disabled
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
: 685834 687381 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-17 22:57 UTC by Rui Matos
Modified: 2017-06-20 02:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
power: Add a watchdog to keep X's builtin screen saver disabled (5.99 KB, patch)
2012-10-17 22:57 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2012-10-17 22:57:34 UTC
I pondered moving this code to gnome-shell instead since that's where
most of gnome-screensaver's functionality moved but seeing as this is
mostly related to DPMS and this is where we're dealing with that I
decided that it would make more sense here.
Comment 1 Rui Matos 2012-10-17 22:57:37 UTC
Created attachment 226703 [details] [review]
power: Add a watchdog to keep X's builtin screen saver disabled

X's builtin screen saver may activate DPMS. Since we want to activate
DPMS ourselves according to our own policy we must make sure that X's
screen saver remains disabled.

This code is a copy of the original found in gs-watcher-x11.c from
gnome-screensaver which stopped being used in GNOME 3.6.
Comment 2 Bastien Nocera 2012-10-18 08:04:56 UTC
Review of attachment 226703 [details] [review]:

Yes!
Comment 3 Rui Matos 2012-10-18 13:27:43 UTC
Attachment 226703 [details] pushed as a7ad352 - power: Add a watchdog to keep
X's builtin screen saver disabled

Added a link to the gnome-screensaver code in the comment.

Should this go in the 3.6 branch as well?
Comment 4 Bastien Nocera 2013-01-13 19:26:11 UTC
*** Bug 687381 has been marked as a duplicate of this bug. ***
Comment 5 Bastien Nocera 2013-02-12 17:43:56 UTC
*** Bug 685834 has been marked as a duplicate of this bug. ***
Comment 6 shaneonabike 2013-08-20 13:56:51 UTC
I'm not sure this is resolved. In Ubuntu 13.04 gnome-settings-daemon 3.6.4 it doesn't work :(

I tried the same tests as above and got the exact same results but the monitor dims regardless. I'll update the other ticket also.

See Bug 687381 for a reference on caffienne plugin. It stopped working after I upgraded to Ubuntu 13.04 and dims the screen.
Comment 7 shaneonabike 2013-08-20 13:57:52 UTC
Sorry (as above) was a bad copy/paste. I tried the tests in Bug 687381 and it resulted in the same positive results but the screen still dims.