After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686265 - scrolledwindow: set GDK_EXPOSURE_MASK on the overshoot window
scrolledwindow: set GDK_EXPOSURE_MASK on the overshoot window
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-10-17 05:15 UTC by Cosimo Cecchi
Modified: 2012-10-17 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scrolledwindow: set GDK_EXPOSURE_MASK on the overshoot window (4.01 KB, patch)
2012-10-17 05:15 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-10-17 05:15:54 UTC 
This is related to https://bugzilla.redhat.com/show_bug.cgi?id=864058
Comment 1 Cosimo Cecchi 2012-10-17 05:15:56 UTC 
Created attachment 226606 [details] [review]
scrolledwindow: set GDK_EXPOSURE_MASK on the overshoot window

Currently we use gtk_style_context_set_background() when the state flags
change in order to propagate the background color to the overshoot
window, but this is actually only needed because the window doesn't get
expose events, since we always draw a full background in draw().
This also fixes some problems when the GdkWindow of the scrolled
window's child is composited, as seen in oxygen-gtk3.
Comment 2 Matthias Clasen 2012-10-17 12:16:48 UTC 
Review of attachment 226606 [details] [review]:

Oh, yes. Much better to just draw the overshoot window regularly.
Comment 3 Cosimo Cecchi 2012-10-17 13:57:28 UTC 
Attachment 226606 [details] pushed as 4c9db15 - scrolledwindow: set GDK_EXPOSURE_MASK on the overshoot window

Thanks, pushed now.