After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686262 - editor: Translate summary and description
editor: Translate summary and description
Status: RESOLVED FIXED
Product: dconf-editor
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: dconf-editor maintainer(s)
dconf-editor maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-10-17 03:45 UTC by Daiki Ueno
Modified: 2015-02-22 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
editor: Translate summary and description (1.36 KB, patch)
2012-10-17 03:45 UTC, Daiki Ueno 		needs-work Details | Review
editor: Translate summary and description (1.41 KB, patch)
2012-10-17 05:27 UTC, Daiki Ueno 		committed Details | Review

Description Daiki Ueno 2012-10-17 03:45:43 UTC 
Now that SchemaKey has gettext_domain field, why not pick the translations for dconf-editor?
Comment 1 Daiki Ueno 2012-10-17 03:45:45 UTC 
Created attachment 226604 [details] [review]
editor: Translate summary and description
Comment 2 Robert Ancell 2012-10-17 04:16:24 UTC 
Review of attachment 226604 [details] [review]:

Just that one fix and it looks good, thanks Daiki!

::: editor/dconf-editor.vala
@@ +221,3 @@
                 if (selected_key.schema.summary != null)
                     summary = selected_key.schema.summary;
+                if (summary != "")

You should also check if gettext_domain is non-NULL as the man page for dgettext says:
"if this argument is NULL, the domain name specified through a preceding textdomain call is used instead"
Comment 3 Daiki Ueno 2012-10-17 05:27:05 UTC 
Created attachment 226607 [details] [review]
editor: Translate summary and description

Check gettext_domain != null as well so not to pick translation from other domain.
Comment 4 Daiki Ueno 2012-11-01 06:57:19 UTC 
Hi, Robert.  What about the new patch?
Anyway, thanks for the review and insightful comment!
Comment 5 Robert Ancell 2012-11-08 01:30:37 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 André Klapper 2015-02-22 12:23:57 UTC 
[moving dconf>editor tickets to dconf-editor product. See bug 744791]