After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686240 - messageTray: Remove hack for the lack of negative units in libcroco
messageTray: Remove hack for the lack of negative units in libcroco
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-16 17:52 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-10-18 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Remove hack for the lack of negative units in libcroco (1.48 KB, patch)
2012-10-16 17:52 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-10-16 17:52:02 UTC 
I've added support for negative units to libcroco in bug #686293.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-10-16 17:52:04 UTC 
Created attachment 226577 [details] [review]
messageTray: Remove hack for the lack of negative units in libcroco

libcroco now has native support for negative units.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-16 18:07:11 UTC 
Croco bug has been fixed. Review on this would be appreciated.
Comment 3 drago01 2012-10-16 22:32:16 UTC 
Review of attachment 226577 [details] [review]:

Looks good but the minimum libcroco version has to be bumped to 0.6.8 in configure.ac
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-18 16:51:08 UTC 
Attachment 226577 [details] pushed as 31ea3f7 - messageTray: Remove hack for the lack of negative units in libcroco


Done.