After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686233 - Error message in 'Run' should use a symbolic icon
Error message in 'Run' should use a symbolic icon
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.6.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-16 16:47 UTC by Reda Lazri
Modified: 2012-10-17 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Example (12.17 KB, image/png)
2012-10-16 16:48 UTC, Reda Lazri 		  Details
runDialog: Use a symbolic icon (1.04 KB, patch)
2012-10-16 16:52 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Reda Lazri 2012-10-16 16:47:59 UTC 
Now it's using a fullcolor icon.
Using GS 3.6.1
Comment 1 Reda Lazri 2012-10-16 16:48:30 UTC 
Created attachment 226571 [details]
Example
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-16 16:52:26 UTC 
Created attachment 226572 [details] [review]
runDialog: Use a symbolic icon

Another fallout from the St.IconType changes
Comment 3 Florian Müllner 2012-10-16 16:57:18 UTC 
Review of attachment 226572 [details] [review]:

> Another fallout from the St.IconType changes

No, it's not[0]. If we want to change the icon to symbolic, the code looks fine ...


[0] http://git.gnome.org/browse/gnome-shell/tree/js/ui/runDialog.js?h=gnome-3-4#n222
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-16 16:59:46 UTC 
Aha. I swore I've seen it as a symbolic icon before, though.
Comment 5 Reda Lazri 2012-10-16 17:03:45 UTC 
Yeah, me too. It was symbolic I think. It even had a class to change its color 'run-dialog-error-icon'. Weird. :\
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-10-16 17:14:53 UTC 
That's because it is a regression.

http://git.gnome.org/browse/gnome-shell/tree/src/st/st-icon.c?h=gnome-3-4#n72
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-10-17 16:24:41 UTC 
Attachment 226572 [details] pushed as 45e64f4 - runDialog: Use a symbolic icon