After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686126 - Whitespace between "-I" and path not portable
Whitespace between "-I" and path not portable
Status: RESOLVED FIXED
Product: libcroco
Classification: Core
Component: General
0.6.x
Other Mac OS
: Normal normal
: ---
Assigned To: libcroco maintainers
libcroco maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-14 22:18 UTC by Daniel Macks
Modified: 2012-10-15 22:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Daniel Macks 2012-10-14 22:18:41 UTC 
libcroco-0.6.6 src/Makefile.am has:

libcroco_0_6_la_CPPFLAGS = \
	-I$(top_srcdir) \
	-I$(top_srcdir)/intl \
	-I $(top_builddir)/src \
	$(AM_CPPFLAGS)

The whitespace between the last -I flag and its associated path is not fully portable to some compilers...they see it as an isolated -I flag (with no path) and then a loose directory-name (as if it were a source-file to compile). Quick-fix is to remove the space (the same construct used in the other -I fields there, for example):

-	-I $(top_builddir)/src \
+	-I$(top_builddir)/src \
Comment 1 Christian Persch 2012-10-14 22:31:15 UTC 
OK to commit the fix to master.
Comment 2 Christian Persch 2012-10-15 22:56:01 UTC 
Fixed on master.