After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686065 - rhythmbox lyrics plugin: catch IO exception while getting lyrics
rhythmbox lyrics plugin: catch IO exception while getting lyrics
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-13 00:15 UTC by Leo Iannacone
Modified: 2018-05-24 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
TryExecpt on callback performs a IO write (438 bytes, patch)
2012-10-13 00:17 UTC, Leo Iannacone
needs-work Details | Review

Description Leo Iannacone 2012-10-13 00:15:54 UTC
It's better surround IO write with a "try - except" block while try to store lyrics on the harddisk.

In this way, if you get some UnicodeError you can skip it and go forward, searching lyrics through other lyrics parsers.
Comment 1 Leo Iannacone 2012-10-13 00:17:04 UTC
Created attachment 226361 [details] [review]
TryExecpt on callback performs a IO write
Comment 2 Jonathan Matthew 2012-10-14 07:01:00 UTC
Review of attachment 226361 [details] [review]:

::: plugins/lyrics/LyricsParse.py
@@ +64,3 @@
+					return
+				except:
+					continue

I don't like this approach at all. The callback should handle the errors you're trying to protect against.
Comment 3 GNOME Infrastructure Team 2018-05-24 17:43:24 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1231.