GNOME Bugzilla – Bug 686065
rhythmbox lyrics plugin: catch IO exception while getting lyrics
Last modified: 2018-05-24 17:43:24 UTC
It's better surround IO write with a "try - except" block while try to store lyrics on the harddisk. In this way, if you get some UnicodeError you can skip it and go forward, searching lyrics through other lyrics parsers.
Created attachment 226361 [details] [review] TryExecpt on callback performs a IO write
Review of attachment 226361 [details] [review]: ::: plugins/lyrics/LyricsParse.py @@ +64,3 @@ + return + except: + continue I don't like this approach at all. The callback should handle the errors you're trying to protect against.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1231.