After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686009 - rtmpsink: handle RTMP_Write() return value correctly
rtmpsink: handle RTMP_Write() return value correctly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.0.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 681111 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-12 07:25 UTC by Sergey Gorshkov
Modified: 2012-10-12 22:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix patch (771 bytes, patch)
2012-10-12 07:25 UTC, Sergey Gorshkov 		committed Details | Review

Description Sergey Gorshkov 2012-10-12 07:25:28 UTC 
Created attachment 226313 [details] [review]
Fix patch

Incorrect RTMP_Write return value check. When RTMP_Write can't write data to server return value is negative (-1) Version of librtmp is 2.4 (current)
Comment 1 Tim-Philipp Müller 2012-10-12 22:37:35 UTC 
Thanks, pushed:

 commit 6d0d209a28bfb88e61bba1cb32bd24c1bfd8f485
 Author: Sergey N. Gorshkov <sng@setevisor.tv>
 Date:   Fri Oct 12 10:57:44 2012 +0400

    rtmpsink: handle RTMP_Write() return value correctly
    
    Error might also be negative (-1). Unclear if 0 should
    be fatal as well though.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=681111
    https://bugzilla.gnome.org/show_bug.cgi?id=686009
Comment 2 Tim-Philipp Müller 2012-10-12 22:40:05 UTC 
*** Bug 681111 has been marked as a duplicate of this bug. ***