After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685936 - gsd-test-* programs miss notify_init()
gsd-test-* programs miss notify_init()
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-11 08:06 UTC by Martin Pitt
Modified: 2012-10-11 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test-plugin: Call notify_init() (1.53 KB, patch)
2012-10-11 08:08 UTC, Martin Pitt
committed Details | Review

Description Martin Pitt 2012-10-11 08:06:16 UTC
I am currently writing some automatic tests ("make check" style for continous integration testing in jhbuild) for the power plugin and would like to use the rather convenient gsd-test-* programs for that. Unfortunately this does not currently work, as it fails with e. g.


(lt-gsd-test-power:14506): power-plugin-DEBUG: charge-action
(lt-gsd-test-power:14506): power-plugin-DEBUG: got filename: battery-missing-symbolic;gpm-battery-missing;gpm-battery-000;battery-missing;

(lt-gsd-test-power:14506): libnotify-WARNING **: you must call notify_init() before showing
**
libnotify:ERROR:notification.c:568:notify_notification_show: code should not be reached


test-plugin.h should call notify_init(), so that the test plugin wrappers behave like the actual gnome-settings-daemon (which also calls it at start).
Comment 1 Martin Pitt 2012-10-11 08:08:19 UTC
Created attachment 226233 [details] [review]
test-plugin: Call notify_init()
Comment 2 Bastien Nocera 2012-10-11 08:11:52 UTC
Pushed to gnome-3-6 and master.

Attachment 226233 [details] pushed as 7f7b720 - test-plugin: Call notify_init()
Comment 3 Martin Pitt 2012-10-11 08:40:35 UTC
Wow, that was fast, thanks Bastien!