After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685921 - Should be possible to use assets in different sizes for checks/radios/arrows
Should be possible to use assets in different sizes for checks/radios/arrows
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkStyleContext
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-10-10 22:00 UTC by David Zeuthen (not reading bugmail)
Modified: 2014-07-10 03:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description David Zeuthen (not reading bugmail) 2012-10-10 22:00:01 UTC
If you specify a non-default indicator size for toggle cell renderers it looks wrong, see

 http://people.freedesktop.org/~david/gtk-cell-renderer-toggle-indicator-size.png

I would expect instead to get a bigger indicator rather than it repeating. If you have a recent gnome-disk-utility checkout just uncomment line 1325 in src/disks/gduwindow.c to reproduce.
Comment 1 Cosimo Cecchi 2012-11-24 21:44:22 UTC
The problem is that drawing a bigger indicator implies we have checkbox assets for different sizes, and a way to read those sizes from the theme, which we currently don't.
What we can do to make it look less broken is to center the image in the area instead of repeating it, which is the fix I pushed to Adwaita now.

Retitling and reassigning to GTK for a real fix; we talked about this with Benjamin in the past and the idea was along these lines:
- you would define a mapping between an unique name + different sizes and its image data in the CSS file, for each check/radio/arrow asset
- gtk_render_check/gtk_render_option etc would just internally render the image, with the same logic for sizing as icon themes (i.e. it would pick the size next to the closest available and so on)
- icon themes would eventually be moved to the same framework
Comment 2 Matthias Clasen 2014-07-10 03:26:46 UTC
I believe this has been satisfied with -gtk-icon-source and -gtk-icontheme in css