After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685916 - GtkMenuButton on a 'osd' GtkToolbar
GtkMenuButton on a 'osd' GtkToolbar
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-10 21:09 UTC by David Zeuthen (not reading bugmail)
Modified: 2018-04-14 23:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description David Zeuthen (not reading bugmail) 2012-10-10 21:09:09 UTC 
In Disks, I have do this and it looks wrong with the button turning light and the menu also being light - I would have expected it to be dark instead. See

 http://people.freedesktop.org/~david/gtk-menu-button-on-osd-toolbar.png

for an example. Code to reproduce is on gnome-disk-utility master. Thanks!
Comment 1 Cosimo Cecchi 2012-10-10 21:50:53 UTC 
I now pushed a fix to git that fixes the white color of the button, which is obviously wrong.

I am not completely sure what to do with the menus here; a possibility is using a different (dark) style for menus linked to an OSD button, probably similar to what we do in the dark theme variation, but I would like to get Jakub's and Lapo's opinion first.
Comment 2 Jakub Steiner 2012-10-11 10:46:45 UTC 
For the sake of simplicity, using the same style as the dark variant would probably be good enough. Knowing Lapo, I'm sure he will want to special case this :)
Comment 3 Lapo Calamandrei 2012-10-11 11:41:42 UTC 
If there's enough contast going dark is ok to me, the menu in general on the osd is weird whatever imho, an osd works better as a strip of buttons.
Also the osd is placed at the bottom of the window so there are good chances that that menu will appear on top of the button which doesn't work at all with our "standard" button-menu design.
Comment 4 Juraj Fiala 2016-06-26 18:08:20 UTC 
Since the gtk3 version of Adwaita was moved into gtk+, these bugs belong there.
Comment 5 Matthias Clasen 2018-02-10 04:54:02 UTC 
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
Comment 6 Matthias Clasen 2018-04-14 23:54:58 UTC 
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla.

If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab:

https://gitlab.gnome.org/GNOME/gtk/issues/new